Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Backport flat reshare unit tests #26926

Closed
wants to merge 806 commits into from

Conversation

PVince81
Copy link
Contributor

Since stable9 already has flat reshares, the unit tests need to also use the new sharing API when creating shares to make sure we're testing the correct results.

Also this is required by #26912 which adds a performance fix that uses a shortcut that limits recursion based on the idea that recursion is not needed any more due to flat reshares.

Required for #26912

Please review @SergioBertolinSG @jvillafanez @DeepDiver1975 @VicDeo

Vincent Petry and others added 30 commits July 1, 2016 11:22
…therfilelists

[stable9] Fix search result link for file results outside default list
* Fix Decrypt message via occ

* Comments fixed

* Fixed reviews

* Originally:
commit 2304e4b
Author: Joas Schilling <nickvergessen@owncloud.com>
Date:   Tue Jun 7 09:13:11 2016 +0200

    Allow to decrypt user '0' files only

* Fix uid comparison
* Initial web executor

* Fix PHPDoc

Fix broken integration test

OccControllerTests do not require database access - moch them all!

Kill unused sprintf
Makes sure that the share owner is set before entering the checks that
need it.

Partial backport of afa37d3
Add integration test for the use case where a group share exists and
then the same owner creates a direct share to a user in that group.
…ble9

[stable9] get only vcards which match both the address book id and the vcard uri
[stable9] Change order of share creation validation
Revert "Remove repair steps for broken updater repair"
…8e99e379449792eeaf8

[stable9] Ignore invalid paths in the JS file list
* Wait for socket to be open

* Fix call on null

* Allow DB access for MountProviderTest

Makes unit tests pass when using object store, since their FS access is
actually oc_filecache DB access. It is currently not possible to mock
or bypass the logic from "SharedMount::verifyMountPoint()" triggered by
this test.
* Filelist change dir auto-prepend slash

Prepend a slash to directories in case it was missing since many places
assume that it's there.

* Fix js unit test in filelist spec
* [stable9] Contacts API: replace raw image data with url

* fix a ImageExportPlugin Test
[stable9] Additional perm check in Webdav
* Workaround to check htaccess in case of redirects

In some setups, the web server will redirect any call to "data/" to the
main page. This causes the XHR to return the 200 HTTP status code and
the body contains the HTML page of the main page / files app.

This fix improves the htaccess failure detection by adding a known
string inside the test file "htaccesstest.txt". If we are able to find
this string, it means that the web server didn't block access to that
file.

* Fix setup check unit test (#25439)
…certificate is revoked (#25469)

* Adding certificate revocation list and validate if the app certificate is revoked

* Check integrity of a signed app in any case on installation
DeepDiver1975 and others added 21 commits November 28, 2016 10:27
[stable9] Use the correct realm for basic authentication - fixes #23427
404 errors were not properly cached due to catching the wrong
exception. Now catching ClientHttpException and checking the error
code. In case of 404, adjust the stat cache accordingly.
Conflicts:
	build/integration/features/webdav-related.feature
…ages

[stable9] Remove obsolete RepairLegacyStorages repair step
Stable9: Do not validate return code if set was successful
[stable9] Fix for app groups setting preservation
…-colons

[Stable9] Add integration test for creating folder with colon
[stable9] Fix DAV stat cache to properly cache 404
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 and @Xenopathic to be potential reviewers.

@PVince81
Copy link
Contributor Author

Wrong branch

@PVince81 PVince81 closed this Jan 11, 2017
@PVince81 PVince81 deleted the stable9-backport-tests-flatreshare branch January 12, 2017 13:49
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.