Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test calendar object with various characters #27914

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 17, 2017

Description

Postgress seems to have issues with some characters - pg being the new mysql?

Related Issue

refs #27426

How Has This Been Tested?

  • run unit test on jenkins for pg - no local pg at the moment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 17, 2017
@PVince81 PVince81 modified the milestones: 10.0.1, 10.0.3 May 31, 2017
@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

@DeepDiver1975 finish this ?

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 finish this ?

will do

@PVince81
Copy link
Contributor

PVince81 commented Aug 7, 2017

@DeepDiver1975 finish this ?

@PVince81
Copy link
Contributor

unfinished -> planned

@PVince81 PVince81 modified the milestones: planned, development Aug 10, 2017
@DeepDiver1975 DeepDiver1975 changed the title [WIP] Test calendar object with various characters Test calendar object with various characters Aug 10, 2017
@PVince81 PVince81 modified the milestones: development, planned Nov 8, 2017
@PVince81 PVince81 modified the milestones: planned, development Nov 22, 2017
@PVince81 PVince81 modified the milestones: development, planned Jan 12, 2018
@owncloud owncloud deleted a comment from codecov bot Feb 20, 2018
@codecov
Copy link

codecov bot commented Feb 20, 2018

Codecov Report

Merging #27914 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #27914      +/-   ##
============================================
+ Coverage     61.61%   61.61%   +<.01%     
- Complexity    18506    18507       +1     
============================================
  Files          1090     1090              
  Lines         61111    61113       +2     
============================================
+ Hits          37651    37653       +2     
  Misses        23460    23460
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 79.97% <100%> (ø) 170 <0> (ø) ⬇️
apps/dav/lib/Connector/Sabre/Auth.php 92.59% <0%> (+0.18%) 34% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823ad2a...afd4ebf. Read the comment docs.

@DeepDiver1975
Copy link
Member Author

@PVince81 finally the issue could be properly reproduced and fixed - we shall backport this. THX

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine if other DBs approve 👍

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants