Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for emojis in various places #34437

Closed
5 tasks done
phil-davis opened this issue Feb 11, 2019 · 11 comments
Closed
5 tasks done

Tests for emojis in various places #34437

phil-davis opened this issue Feb 11, 2019 · 11 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Feb 11, 2019

Issue #34419 provided acceptance tests for emojis embedded in comments, and creating folders with names containing emojis via the API.

Here are a few more places that people could conceivably use emojis:

Using the API:

  • embedded in a group named like "🚴 cycling" (and be able to share with such a group)
  • embedded in a tag name
  • embedded in a user full name (yes, users can do this themselves)
  • passwords with emojis
  • search for file names that contain emojis

Using the webUI:
similar list to API?

Make acceptance tests to verify the above are working.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22492 (test), #31579 (test), #22485 (test), #27914 (Test calendar object with various characters), and #30567 ([stable10] Test calendar object with various characters).

@individual-it
Copy link
Member

one problem we did face today trying to do that is that its difficult to have emojis in XPATH

@individual-it
Copy link
Member

API groupnames with emojis tests in #35247

@davitol
Copy link
Contributor

davitol commented May 21, 2019

* embedded in a tag name

@phil-davis Do you refer to this already created test? https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTags/createTags.feature#L25

If so, let's mark the checkbox of the open post

@individual-it
Copy link
Member

@bhawanaprasain please list the PRs you have done for that issue here

@bhawanaprasain
Copy link
Contributor

@individual-it these are the PRs related to emojis #35247 #35286 #35300 #35315 #35317

@phil-davis
Copy link
Contributor Author

I updated the list in the first post.
Remaining item is using emojis in a user full name.

@phil-davis
Copy link
Contributor Author

Emojis acceptance tests have been done for the above areas using the API.

In the webUI you have to find trickier ways to "type" emojis into fields. See fillFieldWithCharacters() added in PR #34420

@individual-it do we leave this open and try to get emojis working in more parts of the webUI?

@individual-it
Copy link
Member

yes, lets leave it open
@bhawanaprasain please link your new PRs to this issue

@Talank
Copy link
Contributor

Talank commented Jul 19, 2021

@sakshamgurung is working on this

@individual-it
Copy link
Member

more emoji tests were added in #39033 🚀
I think we can close this 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants