Acceptance test for group names with emoji #35247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpakach
reviewed
May 16, 2019
| @@ -44,6 +44,8 @@ Feature: delete groups | |||
| | 50%2Eagle | %2E literal looks like an escaped "." | | |||
| | 50%2Fix | %2F literal looks like an escaped slash | | |||
| | staff?group | Question mark | | |||
| | 😁 😂 | emoji | | |||
|
|
|||
dpakach
reviewed
May 16, 2019
| @@ -22,7 +22,7 @@ Feature: remove a user from a group | |||
| | España | special European characters | | |||
| | नेपाली | Unicode group name | | |||
|
|
|||
| Scenario Outline: admin removes a user from a group | |||
| Scenario Outline: admin removes a user from a group | |||
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #35247 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35247 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
|
restarted build |
|
@dpakach @paurakhsharma @skshetry please review again |
individual-it
approved these changes
May 22, 2019
|
@bhawanaprasain please backport to stable10 branch |
6 tasks
|
Backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these tests we can check if we can use group names with emojis .
Part of issue #34437