Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test for creating password with emoji #35315

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

bhawanaprasain
Copy link
Contributor

@bhawanaprasain bhawanaprasain commented May 23, 2019

Description

Users can create their password including emojis.

Part of issue #34437

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain
Copy link
Contributor Author

@dpakach @paurakhsharma @skshetry please review on my PR .

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #35315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35315   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db604e...e1fbc09. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #35315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35315   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9882365...8773df0. Read the comment docs.

Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis merged commit 5d814e3 into owncloud:master Jun 4, 2019
@phil-davis
Copy link
Contributor

@bhawanaprasain please backport to stable10

@phil-davis
Copy link
Contributor

Backport stable10 #35431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants