Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test scenarios for emojis and Unicode in comments #34420

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Expand test scenarios for emojis and Unicode in comments #34420

merged 1 commit into from
Feb 11, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 8, 2019 •
edited
Loading

Description

Add acceptance test scenarios for:

  • API delete and edit comments that contain emojis and Unicode
  • API create a folder that contains emojis in the name (Unicode scenarios already exist)
  • webUI create, delete, edit comments that contain emojis and Unicode
  • webUI create folders with punctuation characters and Unicode characters

See the comments in fillFieldWithCharacters for information about what I had to do to get emojis into a text box on the webUI.

Note: I have not added a test scenario for creating a folder with emojis in its name on the webUI. fillFieldWithCharacters happily puts the emojis into the "folder name" field. But then we need to somehow get focus into the field and send the enter key, while keeping the emojis in the field. That is a challenge for another day.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis self-assigned this Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34420   +/-   ##
=========================================
  Coverage     64.78%   64.78%           
  Complexity    18372    18372           
=========================================
  Files          1199     1199           
  Lines         69565    69565           
  Branches       1281     1281           
=========================================
  Hits          45065    45065           
  Misses        24127    24127           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.13% <ø> (ø) 18372 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46255e2...e83e5ee. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 8, 2019 •
edited
Loading

Codecov Report

Merging #34420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34420   +/-   ##
=========================================
  Coverage     64.78%   64.78%           
  Complexity    18372    18372           
=========================================
  Files          1199     1199           
  Lines         69565    69565           
  Branches       1281     1281           
=========================================
  Hits          45065    45065           
  Misses        24127    24127           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.13% <ø> (ø) 18372 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8fc9e...9e1133c. Read the comment docs.

@phil-davis phil-davis force-pushed the emojis-in-comments-issue-34419 branch from e83e5ee to 9e1133c Compare February 8, 2019 15:13
phil-davis
phil-davis commented Feb 8, 2019
View reviewed changes
tests/acceptance/features/lib/OwncloudPage.php
Session $session, $xpath, $string
) {
$session->executeScript(
"document.evaluate(`" . $xpath . "`, document).iterateNext().value = \"" . $string . "\";"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea for this kind of JavaScript came from SeleniumHQ/selenium#3257 (comment)
Other ideas welcome.

@phil-davis phil-davis mentioned this pull request Feb 11, 2019
Merged
@PVince81 PVince81 merged commit c354962 into master Feb 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the emojis-in-comments-issue-34419 branch February 11, 2019 07:50
@phil-davis
Copy link
Contributor Author

Backport stable10 #34430

@phil-davis phil-davis mentioned this pull request Jun 18, 2019
Closed
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@individual-it individual-it individual-it approved these changes

@davitol davitol Awaiting requested review from davitol

Assignees

@phil-davis phil-davis

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for emojis in comments
3 participants
@phil-davis @individual-it @PVince81