Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Run webUI tests #30973

Closed
wants to merge 6 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

To check what happens.

@phil-davis phil-davis self-assigned this Apr 1, 2018
@codecov
Copy link

codecov bot commented Apr 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (stable10@d136a7f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #30973   +/-   ##
===========================================
  Coverage            ?   59.88%           
  Complexity          ?    18122           
===========================================
  Files               ?     1188           
  Lines               ?    71356           
  Branches            ?     1246           
===========================================
  Hits                ?    42729           
  Misses              ?    28257           
  Partials            ?      370
Flag Coverage Δ Complexity Δ
#javascript 52.67% <ø> (?) 0 <ø> (?)
#phpunit 60.67% <ø> (?) 18122 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d136a7f...9c80773. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 2, 2018

The 4 commits here that fix or improve acceptance test code have been put into separate PRs for merging:
#30971 Properly remember groups that have been deleted using the webUI
#30974 Silence retried to delete file messages
#30976 Fix webUI acceptance test stalls when checking file content

@phil-davis
Copy link
Contributor Author

This now can achieve 100% pass on webUI on Travis. The problems I have observed are:

Job .51 Edge - webUIPersonalSettings often gets:

  Background:                                                                            # /home/[secure]/build/owncloud/core/tests/acceptance/features/webUIPersonalSettings/changePasswordFromSetting.feature:7
    Given these users have been created:                                                 # FeatureContext::theseUsersHaveBeenCreated()
      | username | password | displayname | email        |
      | user1    | 1234     | User One    | u1@oc.com.np |
    And the user has browsed to the login page                                           # WebUILoginContext::theUserBrowsesToTheLoginPage()
    And the user has logged in with username "user1" and password "1234" using the webUI # WebUILoginContext::theUserLogsInWithUsernameAndPasswordUsingTheWebUI()
    And the user has browsed to the personal general settings page                       # WebUIPersonalGeneralSettingsContext::theUserBrowsesToThePersonalGeneralSettingsPage()
      exception 'SensioLabs\Behat\PageObjectExtension\PageObject\Exception\UnexpectedPageException' with message 'Expected to be on "http://owncloud:8889/index.php/settings/personal?sectionid=general" but found "http://owncloud:8889/index.php/apps/files/?dir=/&fileid=11" instead' in /home/[secure]/build/owncloud/core/lib/composer/sensiolabs/behat-page-object-extension/src/SensioLabs/Behat/PageObjectExtension/PageObject/Page.php:217
      Stack trace:
      #0 /home/[secure]/build/owncloud/core/lib/composer/sensiolabs/behat-page-object-extension/src/SensioLabs/Behat/PageObjectExtension/PageObject/Page.php(186): SensioLabs\Behat\PageObjectExtension\PageObject\Page->verifyUrl(Array)
      #1 /home/[secure]/build/owncloud/core/lib/composer/sensiolabs/behat-page-object-extension/src/SensioLabs/Behat/PageObjectExtension/PageObject/Page.php(58): SensioLabs\Behat\PageObjectExtension\PageObject\Page->verify(Array)
      #2 /tmp/ProxyManagerGeneratedProxy__PM__PagePersonalGeneralSettingsPageGeneratedc303956de969da5da17b06b0ccc6bb7c.php(314): SensioLabs\Behat\PageObjectExtension\PageObject\Page->open(Array)
      #3 /home/[secure]/build/owncloud/core/tests/acceptance/features/bootstrap/WebUIPersonalGeneralSettingsContext.php(61): ProxyManagerGeneratedProxy\__PM__\Page\PersonalGeneralSettingsPage\Generatedc303956de969da5da17b06b0ccc6bb7c->open()
      #4 [internal function]: WebUIPersonalGeneralSettingsContext->theUserBrowsesToThePersonalGeneralSettingsPage()

When I watch the video, it does get to the Personal Settings page. So somehow the underlying code that opens the page gets to the verifyUrl() call a bit early (or the Edge webdriver is slow to tell what page the browser is actually on, or...).

Jobs .64 .65 .67. 70 .71 (various IE11 suites) all failed the first time with:

exception 'WebDriver\Exception\CurlExec' with message 'Payload received from webdriver is not valid json: <html><body><h1>504 Gateway Time-out</h1>
      The server didn't respond in time.

Something goes wrong with the connection through the IE11 webdriver. It passes again after 1 or 2 restarts. That needs some research to see if there is anything we can do better there.

@phil-davis
Copy link
Contributor Author

Related PRs are getting through today's Jenkins CI troubles and should be merged in a few hours. Tomorrow the nightly core stable10 Travis results can be checked and see how much better off we are.

@phil-davis phil-davis closed this Apr 3, 2018
@phil-davis phil-davis deleted the stable10-run-webui-tests branch April 3, 2018 08:46
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant