Silence retried to delete file messages #30974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport |
Codecov Report
@@ Coverage Diff @@
## master #30974 +/- ##
=========================================
Coverage 62.3% 62.3%
Complexity 18208 18208
=========================================
Files 1142 1142
Lines 68176 68176
Branches 1232 1232
=========================================
Hits 42480 42480
Misses 25335 25335
Partials 361 361
Continue to review full report at Codecov.
|
individual-it
requested changes
Apr 3, 2018
| @@ -272,7 +272,7 @@ public function openFile($name, Session $session) { | |||
| * | |||
| * @return void | |||
| */ | |||
| public function deleteFile($name, Session $session, $maxRetries = STANDARDRETRYCOUNT) { | |||
| public function deleteFile($name, Session $session, $expectToDeleteFile = true, $maxRetries = STANDARDRETRYCOUNT) { | |||
There was a problem hiding this comment.
long line makes it harder to review in GitHub
phil-davis
force-pushed
the
silence-retried-to-delete
branch
from
a44c44a to
7656c98
Compare
individual-it
approved these changes
Apr 3, 2018
phil-davis
force-pushed
the
silence-retried-to-delete
branch
from
7656c98 to
8d4a1c1
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the scenario step does not expect the file to be able to be deleted, then do not emit messages about "retried to delete". In this case we know that we are supposed to retry a bit, and then it is expected that we will give up and not be able to delete the file.
In this case, reduce the number of retries so we do not waste so much time rechecking that a delete really cannot be done.
Related Issue
#30897
This "cleanup" is to reduce "noise" in the test output, so that people do not mis-understand what is "normal" and what is a problem.
Motivation and Context
When a test tries to delete a file, and expects that it should not be possible to delete the file, then actually the "Delete" action does not exist in the file actions menu. That is expected and what is being tested for. But while doing the checks, the code emits messages like:
These are disturbing to read in the test output, and can send you off looking for problems in the wrong place, when actually this is expected to happen for these test scenario steps.
When we are doing this kind of "negative" "cannot delete" test, we should not emit this noise.
How Has This Been Tested?
Run a full set of webUI tests on Travis. Inspect the logs and see that these
INFORMATION:messages no longer appear.Types of changes
Checklist: