Skip to content

[stable10] UI tests for reset password #31192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented Apr 19, 2018

backport of #31168
depends on #31144 CI will pass after the fix is merged

@phil-davis
Copy link
Contributor

Planned to merge after 10.0.8 - for 10.0.9...

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For merge after #31144

@phil-davis
Copy link
Contributor

See #31225 for a later rebase of this.

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders ownclouders force-pushed the stable10-reset-password-test branch from a925082 to 6ccf88b Compare April 20, 2018 12:34
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #31192 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #31192      +/-   ##
==============================================
- Coverage       60.24%   60.23%   -0.01%     
+ Complexity      18189    18188       -1     
==============================================
  Files            1194     1194              
  Lines           71781    71772       -9     
  Branches         1248     1248              
==============================================
- Hits            43241    43233       -8     
+ Misses          28170    28169       -1     
  Partials          370      370
Flag Coverage Δ Complexity Δ
#javascript 52.64% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 61.06% <ø> (-0.01%) 18188 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Utils/Scanner.php 81.13% <0%> (-2.99%) 30% <0%> (ø)
lib/private/Share20/ProviderFactory.php 95% <0%> (-0.09%) 16% <0%> (ø)
apps/federatedfilesharing/lib/Notifications.php 48.42% <0%> (-0.07%) 31% <0%> (-1%)
lib/private/Files/Mount/MountPoint.php 93.5% <0%> (ø) 34% <0%> (ø) ⬇️
...ederatedfilesharing/lib/BackgroundJob/RetryJob.php 0% <0%> (ø) 10% <0%> (ø) ⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php 100% <0%> (ø) 3% <0%> (ø) ⬇️
ocs/routes.php 100% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Http/Client/Client.php 88% <0%> (+2%) 17% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ca388...6ccf88b. Read the comment docs.

@phil-davis
Copy link
Contributor

I could do a rebase here within GitHub - good stuff. Code looks good, let's see what CI says.

@phil-davis
Copy link
Contributor

phil-davis commented Apr 20, 2018

No good - webUIManageUsersGroups needs work. Doing that in #31225

@phil-davis
Copy link
Contributor

Done in #31225

@phil-davis phil-davis closed this Apr 21, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants