Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] UI tests for reset password #31225

Merged
merged 1 commit into from
Apr 21, 2018

Conversation

phil-davis
Copy link
Contributor

Backport #31168

@phil-davis
Copy link
Contributor Author

This is a rebased version of PR #31192
I had trouble messing with that backport PR from @paurakhsharma so I made a new PR.

This backport had been stuck waiting for #31144 to be merged.

And other backports are waiting for this to get merged - e.g. backport for #31220 which will quickly remove all this EmailContext stuff again.

It is all easier if the backports happen in order - no conflict mess.

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #31225 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             stable10   #31225    +/-   ##
============================================
  Coverage       60.24%   60.24%            
+ Complexity      18352    18189   -163     
============================================
  Files            1194     1194            
  Lines           71781    71781            
  Branches         1248     1248            
============================================
  Hits            43241    43241            
  Misses          28170    28170            
  Partials          370      370
Flag Coverage Δ Complexity Δ
#javascript 52.64% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 61.07% <ø> (ø) 18189 <ø> (-163) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37991c3...c2c6802. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 20, 2018

I had to add USE_EMAIL: true to webUIManageUsersGroups because it has resetPassword.feature. And webUIManageUsersGroups is no longer in core master - so it is always a bit of a learning experience backporting webUI infrastructure changes from core to stable10

@patrickjahns
Copy link
Contributor

patrickjahns commented Apr 20, 2018

I had to add USE_EMAIL: true to webUIManageUsersGroups because it has resetPassword.feature (and webUIManageUsersGroups is no longer in core master - so it is always a bit of a learning experience backporting webUI infrastructure changes from core to stable10

@DeepDiver1975
that is what i mean by not diverging from the contents of the branches too much

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 20, 2018

At some point it is life - core master has to get new features.
In this case features were taken out of core master. But again, that is life. At some time we have to make progress reducing core.

@phil-davis phil-davis force-pushed the stable10-reset-password-test-2 branch from 0edeec2 to ff36b5f Compare April 20, 2018 15:24
@phil-davis
Copy link
Contributor Author

This works. Now we are stuck because of the Redis problem, and that Travis has these huge cron jobs running. So PR #31229 is waiting... for a few short Travis jobs to get run.

@phil-davis phil-davis force-pushed the stable10-reset-password-test-2 branch from ff36b5f to c2c6802 Compare April 21, 2018 02:09
@phil-davis
Copy link
Contributor Author

Rebased again - the Redis fixes are merged in stable10. I expect CI to pass here now.

@phil-davis phil-davis merged commit 1614c14 into stable10 Apr 21, 2018
@phil-davis phil-davis deleted the stable10-reset-password-test-2 branch April 21, 2018 11:07
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@ownclouders ownclouders mentioned this pull request Jul 4, 2018
5 tasks
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants