Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Acceptance test coding standard changes #31517

Merged
merged 1 commit into from
May 24, 2018

Conversation

phil-davis
Copy link
Contributor

Backport #31516

@phil-davis phil-davis added this to the development milestone May 24, 2018
@phil-davis phil-davis self-assigned this May 24, 2018
@phil-davis phil-davis changed the title Acceptance test coding standard changes [stable10] Acceptance test coding standard changes May 24, 2018
@phil-davis
Copy link
Contributor Author

Doing this backport had quite a few conflicts, due to the differences of the php-cs-fixer changes that are in master and not yet in stable10. I generally selected all the conflicting code from master - that gets various bits of those php-cs-fixer changes along with this backport, which does not hurt anything.

There are 2 less files, because a couple of the changes in master were edits to new code related to ```objectstorestuff, which is not yet instable10``. So, of course, it cannot backport.

@phil-davis phil-davis force-pushed the stable10-phpcs-acceptance-test-code branch from ee1e735 to 7cd473d Compare May 24, 2018 08:15
@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #31517 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #31517   +/-   ##
===========================================
  Coverage       60.36%   60.36%           
  Complexity      18210    18210           
===========================================
  Files            1194     1194           
  Lines           71829    71829           
  Branches         1248     1248           
===========================================
  Hits            43356    43356           
  Misses          28103    28103           
  Partials          370      370
Flag Coverage Δ Complexity Δ
#javascript 52.64% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 61.2% <ø> (ø) 18210 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328d0cd...7cd473d. Read the comment docs.

@phil-davis phil-davis merged commit fb036c1 into stable10 May 24, 2018
@phil-davis phil-davis deleted the stable10-phpcs-acceptance-test-code branch May 24, 2018 14:34
This was referenced May 25, 2018
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants