Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webUI search tests #32772

Merged
merged 1 commit into from
Sep 20, 2018
Merged

webUI search tests #32772

merged 1 commit into from
Sep 20, 2018

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Sep 20, 2018

Description

tests to perform searches on the webUI

Related Issue

How Has This Been Tested?

run tests locally, now let 🤖 do its job

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #32772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32772   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18681    18681           
=========================================
  Files          1177     1177           
  Lines         70284    70284           
  Branches       1270     1270           
=========================================
  Hits          45085    45085           
  Misses        24829    24829           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18681 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34be46d...ea0f98d. Read the comment docs.

Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

* ownCloud
*
* @author Artur Neumann <artur@jankaritech.com>
* @copyright Copyright (c) 2017 Artur Neumann artur@jankaritech.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2017/2018

@individual-it
Copy link
Member Author

backport in #32776

@patrickjahns
Copy link
Contributor

Quick note - will there by API tests ?
It is fine if we have basic acceptance tests on the UI - for more indepth scenario I see API tests more suitable, as the search ( REPORT ) api will be used by desktop/mobile clients as well in the future

@phil-davis
Copy link
Contributor

Yes, this test just checks the existing behavior of the current UI search. It will help with getting started on tests for apps with fancier search capability.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants