Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webUI test theUserOpensTheFolderUsingTheWebUI does not open a file #34254

Closed
3 tasks done
phil-davis opened this issue Jan 25, 2019 · 2 comments
Closed
3 tasks done

webUI test theUserOpensTheFolderUsingTheWebUI does not open a file #34254

phil-davis opened this issue Jan 25, 2019 · 2 comments
Assignees
@phil-davis
Labels
2 - Developing dev:acceptance-tests QA:team

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jan 25, 2019 •
edited
Loading

PR #34216 modified theUserOpensTheFolderUsingTheWebUI so that it can navigate folder-by-folder down a path using the webUI to click and open each folder.

But this method is also used by files_texteditor webUI acceptance tests to open a file.

The code was modified in way that it does not open anything when the item is a file.

  • fix the bug
  • refactor the method
  • give the method a better name and description so we do not forget about it supporting opening a file
@phil-davis phil-davis self-assigned this Jan 25, 2019
@phil-davis phil-davis mentioned this issue Jan 25, 2019
Merged
10 tasks
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22492 (test), #22485 (test), #31579 (test), #32843 (webUI test tags), and #32772 (webUI search tests).

@phil-davis
Copy link
Contributor Author

Finished in QA sprint 21

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@phil-davis phil-davis

Labels
2 - Developing dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phil-davis @ownclouders