Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theUserOpensTheFileOrFolderUsingTheWebUI so it opens a file #34253

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 25, 2019

Description

  1. Adjust the PHPdoc and method name so future readers will realize easily that it can be used to open a file or a folder.
  2. Refactor so that if you pass in a path and say it is to a file, it will first navigate into any folders in the path and then open the file.
  3. Make sure to remember the correct folders that were navigated into.

Related Issue

#34254

Motivation and Context

files_texteditor webUI acceptance tests are failing. Make them great again.

How Has This Been Tested?

Local runs of files_texteditor webUI acceptance tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis force-pushed the fix-theUserOpensTheFileOrFolderUsingTheWebUI branch from ca84d03 to 5f32b04 Compare January 25, 2019 12:49
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #34253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34253   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18363    18363           
=========================================
  Files          1198     1198           
  Lines         69538    69538           
  Branches       1281     1281           
=========================================
  Hits          45035    45035           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18363 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f927d...5f32b04. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #34253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34253   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18363    18363           
=========================================
  Files          1198     1198           
  Lines         69538    69538           
  Branches       1281     1281           
=========================================
  Hits          45035    45035           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18363 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f927d...f529a20. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #34259

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 25, 2019

I need to push this to run CI again in the hope of getting codecov.
PITA having drone passed but can't merge.

@phil-davis phil-davis force-pushed the fix-theUserOpensTheFileOrFolderUsingTheWebUI branch from f529a20 to d2a288b Compare January 25, 2019 16:24
@PVince81 PVince81 merged commit 55c4b78 into master Jan 25, 2019
@PVince81 PVince81 deleted the fix-theUserOpensTheFileOrFolderUsingTheWebUI branch January 25, 2019 16:55
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants