Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webUI tests for federationSharing sub-folder operations #34216

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

paurakhsharma
Copy link
Member

Description

Add webUI tests for federationSharing sub-folder operations

Related Issue

#34150

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paurakhsharma paurakhsharma force-pushed the webUI-federationSharing-subFolder-tests branch from 2733cc2 to 8438066 Compare January 23, 2019 06:06
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #34216 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34216      +/-   ##
============================================
- Coverage     64.75%   64.75%   -0.01%     
  Complexity    18362    18362              
============================================
  Files          1198     1198              
  Lines         69533    69532       -1     
  Branches       1281     1281              
============================================
- Hits          45027    45026       -1     
  Misses        24133    24133              
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.1% <ø> (-0.01%) 18362 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Node/AbstractNode.php 98.18% <0%> (-0.04%) 28% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0f0cc...8438066. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #34216 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34216      +/-   ##
============================================
- Coverage     64.75%   64.75%   -0.01%     
  Complexity    18362    18362              
============================================
  Files          1198     1198              
  Lines         69534    69533       -1     
  Branches       1281     1281              
============================================
- Hits          45028    45027       -1     
  Misses        24133    24133              
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.1% <ø> (-0.01%) 18362 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
apps/dav/lib/Files/FileLocksBackend.php 91.54% <0%> (+1.4%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6512ede...7b13898. Read the comment docs.

@dpakach
Copy link
Contributor

dpakach commented Jan 23, 2019

👍

@paurakhsharma paurakhsharma force-pushed the webUI-federationSharing-subFolder-tests branch from 8438066 to 5729213 Compare January 23, 2019 10:08
@paurakhsharma paurakhsharma force-pushed the webUI-federationSharing-subFolder-tests branch from 5729213 to 7b13898 Compare January 23, 2019 10:16
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpakach
Copy link
Contributor

dpakach commented Jan 23, 2019

Looks good

@PVince81 PVince81 merged commit c255c6c into master Jan 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the webUI-federationSharing-subFolder-tests branch January 23, 2019 15:37
@phil-davis
Copy link
Contributor

@paurakhsharma please backport

@paurakhsharma
Copy link
Member Author

Backport on: #34240

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants