Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of add test copying file different case #33622

Merged
merged 3 commits into from
Nov 22, 2018

Conversation

davitol
Copy link
Contributor

@davitol davitol commented Nov 22, 2018

Backport of: #33605
and #33623

@phil-davis
Copy link
Contributor

phil-davis commented Nov 22, 2018

CI fails because the step text in the new scenario is not valid. I don't know how it passed in master.
See master PR #33623 for adjustments.
We will need to cherry-pick that back to this backport PR to implement the backport "all at once".

@phil-davis phil-davis force-pushed the backport-add-test-copying-file-different-case branch from 6100414 to 316b50c Compare November 22, 2018 12:48
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #33622 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #33622   +/-   ##
===========================================
  Coverage       62.94%   62.94%           
  Complexity      18898    18898           
===========================================
  Files            1242     1242           
  Lines           74130    74130           
  Branches         1293     1293           
===========================================
  Hits            46660    46660           
  Misses          27083    27083           
  Partials          387      387
Flag Coverage Δ Complexity Δ
#javascript 53.33% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.99% <ø> (ø) 18898 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff677b7...316b50c. Read the comment docs.

@phil-davis
Copy link
Contributor

Extra commits added to backport from PR #33623 - it should pass now.

@phil-davis phil-davis merged commit ca77996 into stable10 Nov 22, 2018
@phil-davis phil-davis deleted the backport-add-test-copying-file-different-case branch November 22, 2018 13:24
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants