Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a file case sensitive test #33623

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 22, 2018

Description

Adjust the test scenario so that the 2 files textfile1.txt and TextFile1.txt have different content.
Then check that the correct content is downloaded when downloading each file.

Related Issue

Motivation and Context

Improve the test

How Has This Been Tested?

Local test run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis changed the title Copying a file case sensitive phil Copying a file case sensitive test Nov 22, 2018
@phil-davis
Copy link
Contributor Author

PR #33622 to stable10 has failed CI because of the problem fixed here.
After approval of this PR, the commits here will need to be backported to that stable10 PR.

@phil-davis
Copy link
Contributor Author

master merge CI is failing on drone, e.g.
https://drone.owncloud.com/owncloud/core/12880/457

153 scenarios (151 passed, 2 undefined)
1137 steps (1127 passed, 4 undefined, 6 skipped)
22m14.00s (17.84Mb)

--- FeatureContext has missing steps. Define them with these snippets:

    /**
     * @Given user :arg1 has copied file :arg2 to :arg3 using the WebDAV API
     */
    public function userHasCopiedFileToUsingTheWebdavApi($arg1, $arg2, $arg3)
    {
        throw new PendingException();
    }

This PR will fix it.

@phil-davis
Copy link
Contributor Author

Backport is in #33622

Copy link
Contributor

@davitol davitol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #33623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33623   +/-   ##
=========================================
  Coverage     64.22%   64.22%           
  Complexity    18269    18269           
=========================================
  Files          1193     1193           
  Lines         69077    69077           
  Branches       1277     1277           
=========================================
  Hits          44364    44364           
  Misses        24341    24341           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <ø> (ø) 18269 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1bcf5...b41525e. Read the comment docs.

@phil-davis phil-davis merged commit ae342c2 into master Nov 22, 2018
@phil-davis phil-davis deleted the copying-a-file-case-sensitive-phil branch November 22, 2018 13:17
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants