Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move files_versions related steps #33789

Merged
merged 1 commit into from
Dec 6, 2018
Merged

move files_versions related steps #33789

merged 1 commit into from
Dec 6, 2018

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Dec 6, 2018

Description

move everething that relates to the files_versions app to a separate context

Related Issue

part of #33690

Motivation and Context

make WebDav.php shorter and cleaner

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it
Copy link
Member Author

backport in #33790

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #33789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33789   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69256    69256           
  Branches       1276     1276           
=========================================
  Hits          44567    44567           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2227ea...06a1eec. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #33789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33789   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69256    69256           
  Branches       1276     1276           
=========================================
  Hits          44567    44567           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2227ea...06a1eec. Read the comment docs.

@PVince81 PVince81 merged commit 12beaaf into master Dec 6, 2018
@delete-merged-branch delete-merged-branch bot deleted the filesVersionsContext branch December 6, 2018 12:12
@lock lock bot locked as resolved and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants