cleanup acceptance tests WebDav trait

[individual-it]

• use test helpers where possible e.g. WebDavHelper::makeDavRequest and not WebDav::makeDavRequest
• move helper functions into helpers
• split the whole file into multiple contexts
• sort out lastUploadTime (see pause upload to prevent files with same etag #33795 (review) )
• maybe do similar for delete, which also has a sleep(1) (make a lastDeleteTime property, and get rid of the special ```waits nad deletes file`` step?) Add pause of one second before delete in acceptance test steps #34063
• remove logic duplication between WebDav::findEntryFromPropfindResponse + SearchContext::userSearchesUsingWebDavAPI and WebDav::reportFolder

[ownclouders]

GitMate.io thinks possibly related issues are #22492 (test), #22485 (test), #31579 (test), #32559 (acceptance tests - stop uploading when receiving an error), and #32510 (fix API acceptance test steps, so that they really use old/new webdav path).

[phil-davis]

FeatureContext includes BasicStructure and that includes all the other traits like WebDav

We can consider having different contexts for areas of test functionality that can be logically separated. e.g. keep FeatureContext having all the knowledge about users (and user attributes, password...), groups, whatever else is "core" to nearly every test scenario. And then make other context files for stuff that is specific to particular parts of the testing - TagsContext for example, or WebDavContext

Then we could not have trait files at all (maybe?) and each suite in behat.yml just needs to list the contexts that it needs - like now, but there will be more different contexts.

Comments please...

[phil-davis]

Assigned @paurakhsharma to look into the structure and suggest a design for doing this

[paurakhsharma]

• use test helpers where possible e.g. WebDavHelper::makeDavRequest and not WebDav::makeDavRequest

Doesn't this make our php files longer then it is? @phil-davis @individual-it

[individual-it]

done a bit of work, there is more to do putting it back into backlog

[individual-it]

moving to next sprint for remaining work

[phil-davis]

Added to QA/CI project. First someone needs to spend a few minutes working out what is still of value to do here, and then a useful direction to go.

[dpakach]

Closing this as it is moved to new issue #36770

cc @phil-davis @individual-it