Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move uploadWithAllMechanisms to helper #33854

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Dec 11, 2018

Description

move function to helper and make it simpler

Related Issue

part of #33690

Motivation and Context

make WebDav.php shorter

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

phil-davis
phil-davis previously approved these changes Dec 11, 2018
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

@individual-it individual-it dismissed phil-davis’s stale review December 11, 2018 10:38

its not correct, because also invalid chunking/dav path combinations are tried

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #33854 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33854   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ff6a5...07c9924. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #33854 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33854   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ff6a5...07c9924. Read the comment docs.

@individual-it
Copy link
Member Author

@phil-davis please review again, added check if the combinations are valid

@individual-it
Copy link
Member Author

this change will break at least the guests and files_classifier app.
PRs to fix the apps:

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation looks good.
The old code used to specifically do the valid combinations, rather than looping.

@individual-it
Copy link
Member Author

backport in #33858

@individual-it individual-it merged commit 5f51318 into master Dec 11, 2018
@delete-merged-branch delete-merged-branch bot deleted the moveUploadWithAllMechanisms branch December 11, 2018 11:23
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants