-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move uploadWithAllMechanisms to helper #33854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct.
its not correct, because also invalid chunking/dav path combinations are tried
e6aa54d
to
07c9924
Compare
Codecov Report
@@ Coverage Diff @@
## master #33854 +/- ##
=========================================
Coverage 64.35% 64.35%
Complexity 18309 18309
=========================================
Files 1195 1195
Lines 69255 69255
Branches 1276 1276
=========================================
Hits 44566 44566
Misses 24317 24317
Partials 372 372
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #33854 +/- ##
=========================================
Coverage 64.35% 64.35%
Complexity 18309 18309
=========================================
Files 1195 1195
Lines 69255 69255
Branches 1276 1276
=========================================
Hits 44566 44566
Misses 24317 24317
Partials 372 372
Continue to review full report at Codecov.
|
@phil-davis please review again, added check if the combinations are valid |
this change will break at least the guests and files_classifier app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation looks good.
The old code used to specifically do the valid combinations, rather than looping.
backport in #33858 |
Description
move function to helper and make it simpler
Related Issue
part of #33690
Motivation and Context
make WebDav.php shorter
How Has This Been Tested?
🤖
Types of changes
Checklist:
Open tasks: