Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use guzzle to check comments #34052

Merged
merged 1 commit into from
Jan 7, 2019
Merged

use guzzle to check comments #34052

merged 1 commit into from
Jan 7, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 7, 2019

Description

do not rely on sabre to check comments, use guzzle

Related Issue

part of #34000 and #33690

Motivation and Context

see issue

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it
Copy link
Member Author

backport in #34052

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #34052 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34052   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18340    18340           
=========================================
  Files          1198     1198           
  Lines         69420    69420           
  Branches       1276     1276           
=========================================
  Hits          44964    44964           
  Misses        24087    24087           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18340 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9176b...ddf2424. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #34052 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34052   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18340    18340           
=========================================
  Files          1198     1198           
  Lines         69420    69420           
  Branches       1276     1276           
=========================================
  Hits          44964    44964           
  Misses        24087    24087           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18340 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9176b...ddf2424. Read the comment docs.

@phil-davis phil-davis merged commit da55d26 into master Jan 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the checkCommentsWithGuzzle branch January 7, 2019 11:47
@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants