Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move properties related methods into own context #34115

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 11, 2019

Description

move methods into own context

Related Issue

part of #33690

Motivation and Context

make the WebDav.php shorter and easier to use

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #34115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34115   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18345    18345           
=========================================
  Files          1198     1198           
  Lines         69436    69436           
  Branches       1278     1278           
=========================================
  Hits          44971    44971           
  Misses        24094    24094           
  Partials        371      371
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18345 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70bea4...1457af2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #34115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34115   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18345    18345           
=========================================
  Files          1198     1198           
  Lines         69450    69450           
  Branches       1281     1281           
=========================================
  Hits          44982    44982           
  Misses        24095    24095           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18345 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7264a...49a8363. Read the comment docs.

@individual-it individual-it force-pushed the WebDavPropertiesContext branch from 1457af2 to a2f197a Compare January 11, 2019 08:01
@phil-davis phil-davis merged commit e3565a8 into master Jan 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the WebDavPropertiesContext branch January 11, 2019 14:25
@phil-davis
Copy link
Contributor

phil-davis commented Jan 12, 2019

Backport stable10 #34123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants