Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move public upload/downlod steps into separate context #33998

Merged
merged 1 commit into from
Jan 1, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 1, 2019

Description

move acceptance test steps for public upload/download into own context

Related Issue

Motivation and Context

make files shorter and clearer

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #33998 into master will decrease coverage by 16.23%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #33998       +/-   ##
=============================================
- Coverage     64.77%   48.53%   -16.24%     
=============================================
  Files          1198      109     -1089     
  Lines         69418    10501    -58917     
  Branches       1276     1276               
=============================================
- Hits          44964     5097    -39867     
+ Misses        24085     5035    -19050     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 38.63% <ø> (-27.49%) 0 <ø> (-18340)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1081 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc23df...501f537. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #33998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33998   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18340    18340           
=========================================
  Files          1198     1198           
  Lines         69418    69418           
  Branches       1276     1276           
=========================================
  Hits          44964    44964           
  Misses        24085    24085           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18340 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc23df...a10fd89. Read the comment docs.

@phil-davis
Copy link
Contributor

@individual-it there are some real-looking drone fails

@individual-it
Copy link
Member Author

backport in #33999

@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move acceptance tests for public upload/download into own context
3 participants