-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make listFolder function in WebDav.php to use Guzzle #34013
Conversation
1448be1
to
5ff595c
Compare
Codecov Report
@@ Coverage Diff @@
## master #34013 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18340 18340
=========================================
Files 1198 1198
Lines 69418 69418
Branches 1276 1276
=========================================
Hits 44964 44964
Misses 24085 24085
Partials 369 369
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34013 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18340 18340
=========================================
Files 1198 1198
Lines 69418 69418
Branches 1276 1276
=========================================
Hits 44964 44964
Misses 24085 24085
Partials 369 369
Continue to review full report at Codecov.
|
5ff595c
to
6c78e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
6d3c1f9
to
dbe2542
Compare
dbe2542
to
baef349
Compare
backport in #34024 |
more places need to be changed
Description
make the
listFolder
method to use Guzzle and not SabreRelated Issue
part of #34000 & #33690
Motivation and Context
finally be able to remove sabre from the acceptance tests infrastructure
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: