Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make listFolder function in WebDav.php to use Guzzle #34013

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 3, 2019

Description

make the listFolder method to use Guzzle and not Sabre

Related Issue

part of #34000 & #33690

Motivation and Context

finally be able to remove sabre from the acceptance tests infrastructure

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it force-pushed the listFolderNotUsingSabre branch from 1448be1 to 5ff595c Compare January 3, 2019 08:02
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #34013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34013   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18340    18340           
=========================================
  Files          1198     1198           
  Lines         69418    69418           
  Branches       1276     1276           
=========================================
  Hits          44964    44964           
  Misses        24085    24085           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18340 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a5d45...5ff595c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #34013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34013   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18340    18340           
=========================================
  Files          1198     1198           
  Lines         69418    69418           
  Branches       1276     1276           
=========================================
  Hits          44964    44964           
  Misses        24085    24085           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18340 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb971a...baef349. Read the comment docs.

@individual-it individual-it force-pushed the listFolderNotUsingSabre branch from 5ff595c to 6c78e32 Compare January 3, 2019 08:04
phil-davis
phil-davis previously approved these changes Jan 3, 2019
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@individual-it individual-it force-pushed the listFolderNotUsingSabre branch 2 times, most recently from 6d3c1f9 to dbe2542 Compare January 4, 2019 04:47
@individual-it
Copy link
Member Author

backport in #34024

@individual-it individual-it dismissed phil-davis’s stale review January 4, 2019 06:53

more places need to be changed

@phil-davis phil-davis merged commit 6109c0a into master Jan 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the listFolderNotUsingSabre branch January 4, 2019 08:03
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants