Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI #34187

Closed
wants to merge 1 commit into from
Closed

Trigger CI #34187

wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Issue #34186
See what passes

@phil-davis
Trigger CI
38b50fe 
Issue #34186 
See what passes
@phil-davis phil-davis self-assigned this Jan 20, 2019
@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #34187 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34187      +/-   ##
============================================
+ Coverage     64.76%   64.76%   +<.01%     
  Complexity    18351    18351              
============================================
  Files          1198     1198              
  Lines         69467    69467              
  Branches       1281     1281              
============================================
+ Hits          44989    44993       +4     
+ Misses        24105    24101       -4     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18351 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...38b50fe. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 20, 2019 •
edited
Loading

Codecov Report

Merging #34187 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34187      +/-   ##
============================================
+ Coverage     64.76%   64.76%   +<.01%     
  Complexity    18351    18351              
============================================
  Files          1198     1198              
  Lines         69467    69467              
  Branches       1281     1281              
============================================
+ Hits          44989    44993       +4     
+ Misses        24105    24101       -4     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18351 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...38b50fe. Read the comment docs.

@phil-davis
Copy link
Contributor Author

passes first time

@phil-davis phil-davis closed this Jan 20, 2019
@phil-davis phil-davis deleted the phil-davis-patch-2 branch January 20, 2019 14:03
@phil-davis phil-davis mentioned this pull request Jan 20, 2019
Merged
9 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phil-davis