add before-after share link auth events

[karakayasemi]

Description

Adds before and after events for public share link auths.

Related Issue

The first step for:
#33542, owncloud/brute_force_protection#57

Motivation and Context

To be able to detect and interrupt public link share auth attempts.

How Has This Been Tested?

Unit test and manually.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

I am not sure about the location of the events. As far as I see, adding events in linkShareAuth function is enough. But, if you see any missing place, please let me know.

When this pr merged, I will update here: owncloud/docs#311 (comment)

[codecov]

Codecov Report

Merging #34158 into master will decrease coverage by 16.21%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #34158       +/-   ##
=============================================
- Coverage     64.76%   48.55%   -16.22%     
=============================================
  Files          1198      109     -1089     
  Lines         69467    10525    -58942     
  Branches       1281     1281               
=============================================
- Hits          44989     5110    -39879     
+ Misses        24105     5042    -19063     
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	53.09% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	38.63% <ø> (-27.49%)	0 <ø> (-18351)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1079 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...8fc3033. Read the comment docs.

[codecov]

Codecov Report

Merging #34158 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34158      +/-   ##
============================================
+ Coverage     64.76%   64.77%   +<.01%     
  Complexity    18351    18351              
============================================
  Files          1198     1198              
  Lines         69467    69471       +4     
  Branches       1281     1281              
============================================
+ Hits          44989    44997       +8     
+ Misses        24105    24101       -4     
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	53.09% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.12% <100%> (ø)	18351 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
.../files_sharing/lib/Controllers/ShareController.php	54.37% <100%> (+0.85%)	54 <0> (ø)	⬇️
lib/private/Files/View.php	84.6% <0%> (+0.3%)	398% <0%> (ø)	⬇️
lib/private/DB/Connection.php	66.17% <0%> (+0.73%)	49% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...4fe6d6f. Read the comment docs.

[phil-davis]

Unrelated drone CI fail. I restarted drone, and raised issue #34186 to look into why this is happening too often.

[karakayasemi]

@phil-davis it failed again. I tried to restart the build one more time with drone.io's API, but I could not. Have you any suggestion to make CI green.

[phil-davis]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[phil-davis]

I restart the drone build and it failed again. But I made a fresh PR #34187 (not this code) just to check the drone CI - that passed first time.

Either this code really does make some difference to the test, or something goes wrong because the failing scenarios were only recently merged to master and this PR is a few days old. I tried a rebase, maybe that will help??? But I see that you force-pushed only 1 day ago.

[karakayasemi]

I forced pushed 1 day ago to re-trigger ci with only changing commit message. I hope rebase will work.

[phil-davis]

Special CI magic - it passed!

[sharidas]

Kindly have a look at my comment.

[karakayasemi]

The event dispatcher injected to ShareController class as a non-mock object in here:

core/apps/files_sharing/tests/Controllers/ShareControllerTest.php

Line 87 in 4fe6d6f

$this->eventDispatcher = new EventDispatcher();

I can inject a mock EventDispatcher object and update my tests, but there are other events which are not related to this PR in this class. I should refactor their tests also.

@sharidas both of the cases fine for me. What do you think?

[sharidas]

@sharidas both of the cases fine for me. What do you think?

Humm there are more calls to addListener() . Well just leave it then. At least we can make sure for the new test files we can mock the EventDispatcherInterface and use it in our tests.

[sharidas]

Looks fine to me 👍

[PVince81]

@karakayasemi please backport to stable10

[phil-davis]

Backport stable10 #34399