Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] add before-after share link auth events #34399

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

karakayasemi
Copy link
Contributor

Backport of #34158

Description

Adds before and after events for public share link auths.

Related Issue

The first step for:
#33542, owncloud/brute_force_protection#57

Motivation and Context

To be able to detect and interrupt public link share auth attempts.

How Has This Been Tested?

Manually and unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi self-assigned this Feb 7, 2019
@karakayasemi karakayasemi changed the title add before-after share link auth events [stable10] add before-after share link auth events Feb 7, 2019
Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@karakayasemi
Copy link
Contributor Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@karakayasemi
Copy link
Contributor Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable10@0722d54). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34399   +/-   ##
===========================================
  Coverage            ?   63.48%           
  Complexity          ?    19123           
===========================================
  Files               ?     1264           
  Lines               ?    75198           
  Branches            ?     1288           
===========================================
  Hits                ?    47743           
  Misses              ?    27077           
  Partials            ?      378
Flag Coverage Δ Complexity Δ
#javascript 53.31% <ø> (?) 0 <ø> (?)
#phpunit 64.57% <100%> (?) 19123 <0> (?)
Impacted Files Coverage Δ Complexity Δ
.../files_sharing/lib/Controllers/ShareController.php 54.37% <100%> (ø) 54 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0722d54...a4c5d93. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable10@603c306). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34399   +/-   ##
===========================================
  Coverage            ?   62.74%           
  Complexity          ?    19135           
===========================================
  Files               ?     1264           
  Lines               ?    75236           
  Branches            ?     1291           
===========================================
  Hits                ?    47209           
  Misses              ?    27647           
  Partials            ?      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (?) 0 <ø> (?)
#phpunit 63.75% <100%> (?) 19135 <0> (?)
Impacted Files Coverage Δ Complexity Δ
.../files_sharing/lib/Controllers/ShareController.php 54.37% <100%> (ø) 54 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603c306...30c6286. Read the comment docs.

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@karakayasemi
Copy link
Contributor Author

karakayasemi commented Feb 7, 2019

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@karakayasemi
Copy link
Contributor Author

Unrelated error in git step... Rebased again to try one more time.

@phil-davis phil-davis merged commit 04cee42 into stable10 Feb 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-34158 branch February 7, 2019 17:34
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants