Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of Increase size of login_name from 64 to 255 #34280

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

sharidas
Copy link
Contributor

Increase size of column login_name from 64 to 255.
It would help to accomonate long strings.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Increase the size of login_name column of table oc_authtoken. This would help to use long user name for login. This issue was seen when user was trying to authenticate with long username using OAuth2.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Increasing the size of login_name column of the table oc_authtoken. This would help to use long user name for login.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas self-assigned this Jan 28, 2019
@sharidas sharidas added this to the development milestone Jan 28, 2019
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sharidas
Copy link
Contributor Author

Original PR #34269

@PVince81
Copy link
Contributor

will require release note and also would trigger the next release to be 10.2 instead of 10.1.1 due to DB change that requires downtime

@pmaier1

@sharidas sharidas force-pushed the fix-login_name-column-len-stable10 branch from 7ef3cec to 5ff4311 Compare February 7, 2019 13:22
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable10@8b07840). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34280   +/-   ##
===========================================
  Coverage            ?   63.47%           
  Complexity          ?    19123           
===========================================
  Files               ?     1265           
  Lines               ?    75192           
  Branches            ?     1288           
===========================================
  Hits                ?    47731           
  Misses              ?    27083           
  Partials            ?      378
Flag Coverage Δ Complexity Δ
#javascript 53.31% <ø> (?) 0 <ø> (?)
#phpunit 64.56% <0%> (?) 19123 <2> (?)
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version20190125162909.php 0% <0%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b07840...5ff4311. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #34280 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34280      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
- Complexity      19137    19139       +2     
==============================================
  Files            1264     1265       +1     
  Lines           75278    75281       +3     
  Branches         1291     1291              
==============================================
  Hits            47805    47805              
- Misses          27093    27096       +3     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <0%> (-0.01%) 19139 <2> (+2)
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version20190125162909.php 0% <0%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cee42...dbcbb67. Read the comment docs.

@phil-davis
Copy link
Contributor

drone https://drone.owncloud.com/owncloud/core/14918/247 got:

Initialized empty Git repository in /drone/src/.git/
+ git remote add origin https://github.com/owncloud/core.git
+ git fetch --no-tags --depth=50 origin +refs/pull/34280/merge:
fatal: The remote end hung up unexpectedly
time="2019-02-07T15:31:02Z" level=fatal msg="exit status 128" 

stupid thing! I will ask for a rebase again.

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders ownclouders force-pushed the fix-login_name-column-len-stable10 branch from 5ff4311 to d177479 Compare February 7, 2019 16:08
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Increase size of column login_name from 64 to 255.
It would help to accomonate long strings.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@ownclouders ownclouders force-pushed the fix-login_name-column-len-stable10 branch from d177479 to dbcbb67 Compare February 8, 2019 01:13
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis phil-davis merged commit b5fe5c7 into stable10 Feb 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-login_name-column-len-stable10 branch February 8, 2019 02:10
@phil-davis phil-davis mentioned this pull request Feb 18, 2019
11 tasks
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants