-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stable10 to 10.2.0 #34534
Bump stable10 to 10.2.0 #34534
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #34534 +/- ##
===========================================
Coverage 64% 64%
Complexity 19247 19247
===========================================
Files 1276 1276
Lines 75801 75801
Branches 1291 1291
===========================================
Hits 48515 48515
Misses 26907 26907
Partials 379 379
Continue to review full report at Codecov.
|
this would qualify as a process change. usually we only increase the version at the time we do the release, see https://github.com/owncloud/administration-internal/tree/master/release-scripts#b---increase-version-number-in-version-file to reconsider this, we need to make sure that this won't cause other side effects |
c2b9b87
to
6e469dc
Compare
@phil-davis should we setup a discussion to discuss the requirements of QA in regards to fixed version numbers and examine alternatives ? |
@PVince81 I am happy to discuss anything ;) IMO the thing to do is to bump the version number in a branch (e.g. For example (starting from a future imaginary 10.4)
|
6e469dc
to
5b6017b
Compare
now thinking of it, I don't see any strong objections for not bumping the version. after all, if we'd choose to do an alpha or beta tarball release we'd need to bump the version anyway and I wouldn't use a release branch for those (at least not for now with the old branching model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Bump the version in stable10 from 10.1 to 10.2 prealpha
Related Issue
Reasons to bump the minor version include:
#34492 "Add confirm password after new password" has provided a new feature (not just a bug fix)
#34280 "Backport of Increase size of login_name from 64 to 255" has a database migration
I guess there might be other things that are not just bugfixes to 10.1.0
Motivation and Context
Reflect the truth of what is in stable10 that has been merged since 10.1 was released.
There are some new acceptance tests in stable10 that do not work on 10.1-release. We need to skip those for at least 10.1.0, so we need to bump the version anyway.
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: