Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test remote shares ocs endpoint #34641

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Test remote shares ocs endpoint #34641

merged 2 commits into from
Feb 28, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Feb 28, 2019 •
edited
Loading

Description

more tests for the /remote_shares and /remote_shares/pending/ endponts

Related Issue

part of #34566

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it self-assigned this Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34641 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34641      +/-   ##
============================================
- Coverage     65.23%   65.23%   -0.01%     
  Complexity    18438    18438              
============================================
  Files          1203     1203              
  Lines         69825    69825              
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
- Misses        23904    23906       +2     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.63% <ø> (-0.01%) 18438 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6332f...64eed56. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited
Loading

Codecov Report

Merging #34641 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34641      +/-   ##
============================================
- Coverage     65.23%   65.23%   -0.01%     
  Complexity    18438    18438              
============================================
  Files          1203     1203              
  Lines         69825    69825              
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
- Misses        23904    23906       +2     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.63% <ø> (-0.01%) 18438 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6332f...6089f49. Read the comment docs.

phil-davis
phil-davis reviewed Feb 28, 2019
View reviewed changes
tests/acceptance/features/apiFederation/federated.feature Outdated
@@ -66,6 +66,53 @@ Feature: federated
| mountpoint | {{TemporaryMountPointName#/textfile0.txt}} |
| accepted | 0 |

Scenario: Remote sharee requests informations of only one share
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/informations/information

tests/acceptance/features/apiFederation/federated.feature Outdated
| permissions | 27 |

@issue-34636
Scenario: Remote sharee requests informations of only one share before accepting it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/informations/information

tests/acceptance/features/bootstrap/FederationContext.php Outdated
@@ -130,6 +133,55 @@ public function userFromServerHasAcceptedLastPendingShare($user, $server) {
$this->featureContext->theOCSStatusCodeShouldBe('100');
}

/**
* @When /^user "([^"]*)" gets informations of last federated cloud share using the sharing API$/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/get informations of last federated cloud share/retrieves the information of the last federated cloud share

e.g. we have existing steps like:

@When /^the administrator retrieves the information of user "([^"]*)" using the provisioning API$/

so we can be consistent with that.

tests/acceptance/features/bootstrap/FederationContext.php Outdated
}

/**
* @When /^user "([^"]*)" gets informations of last pending federated cloud share using the sharing API$/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/get informations of last pending federated cloud share/retrieves the information of the last pending federated cloud share

@DeepDiver1975 DeepDiver1975 merged commit aeb9857 into master Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the testRemoteSharesOCSEndpoint branch February 28, 2019 09:06
@individual-it individual-it mentioned this pull request Feb 28, 2019
Merged
@individual-it
Copy link
Member Author

backport in #34644

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@individual-it individual-it

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @phil-davis @DeepDiver1975