Test remote shares ocs endpoint

tests/TestHelpers/SharingHelper.php

@@ -195,4 +195,24 @@ public static function getPermissionSum($permissions) {
 		}
 		return $permissionSum;
 	}
+
+	/**
+	 *
+	 * @param \SimpleXMLElement $responseXmlObject
+	 * @param string $errorMessage
+	 *
+	 * @throws \Exception
+	 *
+	 * @return string
+	 */
+	public static function getLastShareIdFromResponse(
+		$responseXmlObject, $errorMessage = "cannot find share id in response"
+	) {
+		$xmlPart = $responseXmlObject->xpath("//data/element[last()]/id");
+
+		if (!\is_array($xmlPart) || (\count($xmlPart) === 0)) {
+			throw new \Exception($errorMessage);
+		}
+		return $xmlPart[0]->__toString();
+	}
 }

tests/acceptance/features/apiFederation/federated.feature

@@ -66,6 +66,53 @@ Feature: federated
       | mountpoint  | {{TemporaryMountPointName#/textfile0.txt}} |
       | accepted    | 0                                          |
 
+  Scenario: Remote sharee requests information of only one share
+    Given user "user0" from server "REMOTE" has shared "/textfile0.txt" with user "user1" from server "LOCAL"
+    And user "user1" from server "LOCAL" has accepted the last pending share
+    When user "user1" retrieves the information of the last federated cloud share using the sharing API
+    Then the OCS status code should be "100"
+    And the HTTP status code should be "200"
+    And the fields of the last response should include
+      | id          | A_NUMBER           |
+      | remote      | REMOTE             |
+      | remote_id   | A_NUMBER           |
+      | share_token | A_TOKEN            |
+      | name        | /textfile0.txt     |
+      | owner       | user0              |
+      | user        | user1              |
+      | mountpoint  | /textfile0 (2).txt |
+      | accepted    | 1                  |
+      | type        | file               |
+      | permissions | 27                 |
+
+  @issue-34636
+  Scenario: Remote sharee requests information of only one share before accepting it
+    Given user "user0" from server "REMOTE" has shared "/textfile0.txt" with user "user1" from server "LOCAL"
+    When user "user1" retrieves the information of the last pending federated cloud share using the sharing API
+    Then the HTTP status code should be "200"
+    And the body of the response should be empty
+    #And the OCS status code should be "100"
+    #And the fields of the last response should include
+    #  | id          | A_NUMBER                                   |
+    #  | remote      | REMOTE                                     |
+    #  | remote_id   | A_NUMBER                                   |
+    #  | share_token | A_TOKEN                                    |
+    #  | name        | /textfile0.txt                             |
+    #  | owner       | user0                                      |
+    #  | user        | user1                                      |
+    #  | mountpoint  | {{TemporaryMountPointName#/textfile0.txt}} |
+    #  | accepted    | 0                                          |
+
+  Scenario: sending a GET request to a pending remote share is not valid
+    When user "user1" sends HTTP method "GET" to OCS API endpoint "/apps/files_sharing/api/v1/remote_shares/pending/12"
+    Then the HTTP status code should be "405"
+    And the body of the response should be empty
+
+  Scenario: sending a GET request to a not existing remote share
+    When user "user1" sends HTTP method "GET" to OCS API endpoint "/apps/files_sharing/api/v1/remote_shares/9999999999"
+    Then the OCS status code should be "404"
+    And the HTTP status code should be "200"
+
   Scenario: accept a pending remote share
     Given user "user0" from server "REMOTE" has shared "/textfile0.txt" with user "user1" from server "LOCAL"
     When user "user1" from server "LOCAL" accepts the last pending share using the sharing API

tests/acceptance/features/bootstrap/BasicStructure.php

@@ -1941,6 +1941,17 @@ public function theFileShouldNotExistInTheServerRoot($path) {
 		);
 	}
 
+	/**
+	 * @Then the body of the response should be empty
+	 *
+	 * @return void
+	 */
+	public function theResponseBodyShouldBeEmpty() {
+		PHPUnit_Framework_Assert::assertEmpty(
+			$this->getResponse()->getBody()->getContents()
+		);
+	}
+
 	/**
 	 * @param ResponseInterface|null $response
 	 *

tests/acceptance/features/bootstrap/FederationContext.php

@@ -24,6 +24,7 @@
 
 use Behat\Behat\Context\Context;
 use Behat\Behat\Hook\Scope\BeforeScenarioScope;
+use TestHelpers\SharingHelper;
 
 require_once 'bootstrap.php';
 
@@ -105,7 +106,9 @@ public function userFromServerAcceptsLastPendingShareUsingTheSharingAPI($user, $
 		$this->userGetsTheListOfPendingFederatedCloudShares($user);
 		$this->featureContext->theHTTPStatusCodeShouldBe('200');
 		$this->featureContext->theOCSStatusCodeShouldBe('100');
-		$share_id = $this->featureContext->getResponseXml()->data[0]->element[0]->id;
+		$share_id = SharingHelper::getLastShareIdFromResponse(
+			$this->featureContext->getResponseXml()
+		);
 		$this->featureContext->theUserSendsToOcsApiEndpointWithBody(
 			'POST',
 			"/apps/files_sharing/api/v1/remote_shares/pending/{$share_id}",
@@ -130,6 +133,55 @@ public function userFromServerHasAcceptedLastPendingShare($user, $server) {
 		$this->featureContext->theOCSStatusCodeShouldBe('100');
 	}
 
+	/**
+	 * @When /^user "([^"]*)" retrieves the information of the last federated cloud share using the sharing API$/
+	 *
+	 * @param string $user
+	 *
+	 * @return void
+	 */
+	public function userRetrievesInformationOfLastFederatedShare($user) {
+		$this->featureContext->userSendsHTTPMethodToOcsApiEndpointWithBody(
+			$user,
+			'GET',
+			"/apps/files_sharing/api/v1/remote_shares",
+			null
+		);
+		$this->featureContext->theHTTPStatusCodeShouldBe('200');
+		$this->featureContext->theOCSStatusCodeShouldBe('100');
+		$share_id = SharingHelper::getLastShareIdFromResponse(
+			$this->featureContext->getResponseXml()
+		);
+		$this->featureContext->userSendsHTTPMethodToOcsApiEndpointWithBody(
+			$user,
+			'GET',
+			"/apps/files_sharing/api/v1/remote_shares/{$share_id}",
+			null
+		);
+	}
+
+	/**
+	 * @When /^user "([^"]*)" retrieves the information of the last pending federated cloud share using the sharing API$/
+	 *
+	 * @param string $user
+	 *
+	 * @return void
+	 */
+	public function userRetrievesInformationOfLastPendingFederatedShare($user) {
+		$this->userGetsTheListOfPendingFederatedCloudShares($user);
+		$this->featureContext->theHTTPStatusCodeShouldBe('200');
+		$this->featureContext->theOCSStatusCodeShouldBe('100');
+		$share_id = SharingHelper::getLastShareIdFromResponse(
+			$this->featureContext->getResponseXml()
+		);
+		$this->featureContext->userSendsHTTPMethodToOcsApiEndpointWithBody(
+			$user,
+			'GET',
+			"/apps/files_sharing/api/v1/remote_shares/{$share_id}",
+			null
+		);
+	}
+
 	/**
 	 * @When /^user "([^"]*)" gets the list of pending federated cloud shares using the sharing API$/
 	 *