Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] test ocs endpoints with invalid credentials #34645

Merged
merged 5 commits into from
Feb 28, 2019

Conversation

individual-it
Copy link
Member

backport of #34643

@individual-it
Copy link
Member Author

please note stable10 does not suffer of #34626

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34645 into stable10 will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34645      +/-   ##
==============================================
+ Coverage       63.73%   63.98%   +0.24%     
  Complexity      19227    19227              
==============================================
  Files            1272     1272              
  Lines           75724    75724              
  Branches         1291     1291              
==============================================
+ Hits            48264    48453     +189     
+ Misses          27081    26892     -189     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.13% <ø> (+0.27%) 19227 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.1% <0%> (+0.06%) 502% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.57% <0%> (+1.81%) 105% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.06% <0%> (+3.48%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (+6.17%) 25% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1086707...3dabf04. Read the comment docs.

@phil-davis phil-davis merged commit d55f2b1 into stable10 Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-testOcsWrongPassword branch February 28, 2019 14:49
@phil-davis
Copy link
Contributor

Note: apiMain suite now took 13 minutes. apiAuth suite took 21 minutes. So splitting that was "a good thing"

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants