Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stable-10] Send requests in loop rather than scenario outline to speed up CI #35472

Closed
wants to merge 1 commit into from
Closed

[Stable-10] Send requests in loop rather than scenario outline to speed up CI #35472

wants to merge 1 commit into from

Conversation

bhawanaprasain
Copy link
Contributor

Backport on: #35395

Description

These tests speedup CI .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@phil-davis
Copy link
Contributor

@bhawanaprasain there are more lines deleted from tests/acceptance/features/apiAuthOcs/ocsGETAuth.feature than happened in core master

I think this feature had some differences in stable10

Can you explain what happened?

@phil-davis phil-davis mentioned this pull request Jun 12, 2019
Merged
4 tasks
@bhawanaprasain bhawanaprasain changed the title [Stable-10] Test for speeding up CI [Stable-10] Send requests in loop rather than scenario outline to speed up CI Jun 17, 2019
@bhawanaprasain
Copy link
Contributor Author

@phil-davis I have found no differences in this backport and PR #35395 .

@individual-it
Copy link
Member

the problem is in #34645 🙈

@individual-it individual-it mentioned this pull request Jun 17, 2019
Merged
11 tasks
@individual-it
Copy link
Member

should be fine after #35548 maybe a rebase will be needed

@phil-davis
Copy link
Contributor

@bhawanaprasain please rebase and resolve the conflict. (or make a new backport branch and PR)
This should work better now that #35548 has been merged to stable10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it Awaiting requested review from individual-it

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@bhawanaprasain bhawanaprasain

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhawanaprasain @phil-davis @individual-it