Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send requests in loop rather than scenario outline to speed up CI #35395

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Send requests in loop rather than scenario outline to speed up CI #35395

merged 1 commit into from
Jun 10, 2019
+243 −121

Conversation

bhawanaprasain
Copy link
Contributor

Description

These tests speedup CI .

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@bhawanaprasain
Copy link
Contributor Author

@dpakach @paurakhsharma @skshetry please review on my PR.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #35395 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35395   +/-   ##
=========================================
  Coverage     65.63%   65.63%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70595    70595           
  Branches       1288     1288           
=========================================
  Hits          46335    46335           
  Misses        23883    23883           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4e13d...f9aad3e. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #35395 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35395   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9285c...bcfa9b4. Read the comment docs.

@dpakach dpakach changed the title Test for speeding up CI Send requests in loop rather than scenario outline to speed up CI Jun 3, 2019
dpakach
dpakach reviewed Jun 3, 2019
View reviewed changes
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
@bhawanaprasain bhawanaprasain force-pushed the runtimeminimizer branch 2 times, most recently from 3d83ea7 to ec34ed3 Compare June 4, 2019 10:33
@bhawanaprasain
Copy link
Contributor Author

@dpakach @paurakhsharma @skshetry please review again.

individual-it
individual-it requested changes Jun 5, 2019
View reviewed changes
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiAuthOcs/ocsGETAuth.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
@bhawanaprasain bhawanaprasain force-pushed the runtimeminimizer branch 2 times, most recently from dc795c8 to 5c079c7 Compare June 5, 2019 06:14
phil-davis
phil-davis reviewed Jun 5, 2019
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to make the text of each step have consistent words.

tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
@individual-it individual-it mentioned this pull request Jun 6, 2019
Merged
6 tasks
phil-davis
phil-davis reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments remaining now.

tests/acceptance/features/bootstrap/Auth.php Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

@bhawanaprasain because of core CI trouble overnight, you will need to rebase to latest master as well as fixing up the review comments.

@individual-it individual-it merged commit 6583ab3 into owncloud:master Jun 10, 2019
@individual-it
Copy link
Member

@bhawanaprasain please backport to stable10

@bhawanaprasain bhawanaprasain mentioned this pull request Jun 11, 2019
Closed
6 tasks
@phil-davis
Copy link
Contributor

phil-davis commented Jun 12, 2019 •
edited
Loading

Backport stable10 #35587

@bhawanaprasain bhawanaprasain mentioned this pull request Jun 19, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis left review comments

@individual-it individual-it individual-it approved these changes

@paurakhsharma paurakhsharma Awaiting requested review from paurakhsharma

@skshetry skshetry Awaiting requested review from skshetry

Assignees

@bhawanaprasain bhawanaprasain

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhawanaprasain @phil-davis @individual-it @dpakach