Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable-10] Send requests in loop rather than scenario outline to speed up CI #35587

Merged

Conversation

bhawanaprasain
Copy link
Contributor

Backport on: #35395

Description

These tests speedup CI .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain
Copy link
Contributor Author

@dpakach @paurakhsharma @skshetry please review on my PR.

@phil-davis
Copy link
Contributor

This looks good. After CI passes we can merge, then you will be able to make other backports easily on top.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #35587 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35587   +/-   ##
===========================================
  Coverage       64.81%   64.81%           
  Complexity      20205    20205           
===========================================
  Files            1294     1294           
  Lines           77253    77253           
  Branches         1301     1301           
===========================================
  Hits            50070    50070           
  Misses          26798    26798           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.96% <ø> (ø) 20205 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6e951...29f3318. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #35587 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35587   +/-   ##
===========================================
  Coverage       64.81%   64.81%           
  Complexity      20205    20205           
===========================================
  Files            1294     1294           
  Lines           77253    77253           
  Branches         1301     1301           
===========================================
  Hits            50070    50070           
  Misses          26798    26798           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.96% <ø> (ø) 20205 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6e951...29f3318. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants