Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for speeding up CI #35434

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

bhawanaprasain
Copy link
Contributor

Description

These tests help to speedup CI by sending requests in loops rather than in scenario outline.

Motivation and Context

Sending HTTP requests to endpoints using scenario outline takes considerable time .If we send these requests in loops time required to get status code minimizes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain
Copy link
Contributor Author

@individual-it @phil-davis please review on my PR.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #35434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35434   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760d0ce...eb9a5fa. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #35434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35434   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18756    18756           
=========================================
  Files          1222     1222           
  Lines         70872    70872           
  Branches       1289     1289           
=========================================
  Hits          46540    46540           
  Misses        23954    23954           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (ø) 18756 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6ee10...1fa69e9. Read the comment docs.

@individual-it
Copy link
Member

need to be on top of #35395
and should use as much as possible the steps created there

@phil-davis
Copy link
Contributor

@bhawanaprasain this will be good to have. apiAuthOCS suite is one of the slowest, so it will be good to speed it up.
Please rebase and resolve conflicts.

@bhawanaprasain
Copy link
Contributor Author

@paurakhsharma @dpakach @skshetry please review on my PR.

Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, please have a look

@bhawanaprasain bhawanaprasain force-pushed the speedupCI branch 2 times, most recently from e70d654 to bec9b35 Compare June 17, 2019 04:44
@individual-it individual-it merged commit 0eda5a5 into owncloud:master Jun 18, 2019
@phil-davis
Copy link
Contributor

Backport stable10 #35586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants