Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10]skeletonfilessharing #35537

Merged

Conversation

bhawanaprasain
Copy link
Contributor

@bhawanaprasain bhawanaprasain commented Jun 14, 2019

Backport on: #35455

Description

It includes API test when receiver has matching file name .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes

@phil-davis
Copy link
Contributor

What happened? This PR adds 19 lines. But the master PR #35434 has few hundred lines of diffs.

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #35537 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35537   +/-   ##
===========================================
  Coverage        64.8%    64.8%           
  Complexity      20201    20201           
===========================================
  Files            1294     1294           
  Lines           77237    77237           
  Branches         1300     1300           
===========================================
  Hits            50054    50054           
  Misses          26799    26799           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.96% <ø> (ø) 20201 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343f593...31c3cbe. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #35537 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35537   +/-   ##
===========================================
  Coverage        64.8%    64.8%           
  Complexity      20201    20201           
===========================================
  Files            1294     1294           
  Lines           77237    77237           
  Branches         1300     1300           
===========================================
  Hits            50054    50054           
  Misses          26799    26799           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.96% <ø> (ø) 20201 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343f593...31c3cbe. Read the comment docs.

@individual-it
Copy link
Member

@phil-davis this is the backport of #35455 that also has 19 lines

@individual-it
Copy link
Member

comment above was fixed

@individual-it individual-it merged commit 2922499 into owncloud:stable10 Jun 17, 2019
@phil-davis
Copy link
Contributor

@phil-davis this is the backport of #35455 that also has 19 lines

OK, the master PR number was wrong the first time and has been corrected now in the original post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants