-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing progress bar in files drop view #35032
Conversation
The uploader is expecting the progress bar element to be in the DOM when created. This fix makes sure to append the PublicUploadView's element to the DOM before rendering it.
Codecov Report
@@ Coverage Diff @@
## master #35032 +/- ##
=========================================
Coverage 65.37% 65.37%
Complexity 18622 18622
=========================================
Files 1215 1215
Lines 70510 70510
Branches 1295 1295
=========================================
Hits 46095 46095
Misses 24041 24041
Partials 374 374
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #35032 +/- ##
=========================================
Coverage 65.37% 65.37%
Complexity 18622 18622
=========================================
Files 1215 1215
Lines 70510 70510
Branches 1295 1295
=========================================
Hits 46095 46095
Misses 24041 24041
Partials 374 374
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35032 +/- ##
=========================================
Coverage 65.37% 65.37%
Complexity 18622 18622
=========================================
Files 1215 1215
Lines 70510 70510
Branches 1295 1295
=========================================
Hits 46095 46095
Misses 24041 24041
Partials 374 374
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
The uploader is expecting the progress bar element to be in the DOM when
created. This fix makes sure to append the PublicUploadView's element to
the DOM before rendering it.
Related Issue
https://github.com/owncloud/enterprise/issues/3281
Regression introduced through #32170 where the progress bar stops working.
Motivation and Context
How Has This Been Tested?
Manual test.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: