Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing progress bar in files drop view #35032

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

PVince81
Copy link
Contributor

Description

The uploader is expecting the progress bar element to be in the DOM when
created. This fix makes sure to append the PublicUploadView's element to
the DOM before rendering it.

Related Issue

https://github.com/owncloud/enterprise/issues/3281

Regression introduced through #32170 where the progress bar stops working.

Motivation and Context

How Has This Been Tested?

Manual test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • backport to release-10.2.0

The uploader is expecting the progress bar element to be in the DOM when
created. This fix makes sure to append the PublicUploadView's element to
the DOM before rendering it.
@PVince81 PVince81 added this to the QA milestone Apr 16, 2019
@PVince81 PVince81 requested review from VicDeo and sharidas April 16, 2019 20:43
@PVince81 PVince81 self-assigned this Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #35032 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35032   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <0%> (ø) 0 <0> (ø) ⬇️
#phpunit 66.81% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2c425...92f4e60. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #35032 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35032   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <0%> (ø) 0 <0> (ø) ⬇️
#phpunit 66.81% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2c425...92f4e60. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #35032 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35032   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <0%> (ø) 0 <0> (ø) ⬇️
#phpunit 66.81% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2c425...92f4e60. Read the comment docs.

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PVince81 PVince81 merged commit ec033b2 into master Apr 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-file-drop-progress branch April 18, 2019 07:25
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants