Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix missing progress bar in files drop view #35110

Closed
wants to merge 0 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 26, 2019

Backport #35032
so that stable10 QA tarball is more up-to-date

Note: has also been backported to release-10.2.0 in PR #35059

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #35110 into stable10 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35110      +/-   ##
==============================================
+ Coverage       64.46%   64.46%   +<.01%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
+ Hits            49594    49595       +1     
+ Misses          26953    26952       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <0%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5a04...e741745. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #35110 into stable10 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35110      +/-   ##
==============================================
+ Coverage       64.46%   64.46%   +<.01%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
+ Hits            49594    49595       +1     
+ Misses          26953    26952       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <0%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5a04...e741745. Read the comment docs.

@phil-davis phil-davis closed this May 24, 2019
@phil-davis phil-davis force-pushed the stable10-fix-file-drop-progress branch from e741745 to 2798149 Compare May 24, 2019 10:53
@phil-davis phil-davis deleted the stable10-fix-file-drop-progress branch May 24, 2019 10:53
@phil-davis
Copy link
Contributor Author

change was merged from release-10.2.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant