Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Point to current installation instructions in README #35037

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 17, 2019

Backport #35036

Note: I including the 2nd commit from the master PR because it seems reasonable to just keep the README in stable10 pointing to the latest docs. Otherwise we have to remember to bump this with every minor version release. And actually people will anyway mostly use this link from the master branch on the default GitHub UI page.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #35037 into stable10 will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35037      +/-   ##
==============================================
- Coverage       64.46%   64.19%   -0.27%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
- Hits            49594    49387     -207     
- Misses          26953    27160     +207     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.38% <ø> (-0.3%) 20064 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
lib/private/DB/OracleMigrator.php 0% <0%> (-80.71%) 29% <0%> (ø)
lib/private/DB/OracleConnection.php 0% <0%> (-66.67%) 12% <0%> (ø)
lib/private/DB/Adapter.php 82.71% <0%> (-6.18%) 25% <0%> (ø)
lib/private/DB/ConnectionFactory.php 78.94% <0%> (-3.95%) 21% <0%> (ø)
lib/private/Repair/RepairMismatchFileCachePath.php 94.57% <0%> (-3.49%) 51% <0%> (ø)
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (-2.74%) 17% <0%> (ø)
lib/private/AllConfig.php 92.46% <0%> (-2.06%) 43% <0%> (ø)
lib/private/Files/Cache/Cache.php 95.82% <0%> (-1.8%) 110% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ada5c...364035c. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #35037 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35037   +/-   ##
===========================================
  Coverage       64.46%   64.46%           
  Complexity      20064    20064           
===========================================
  Files            1286     1286           
  Lines           76928    76928           
  Branches         1307     1307           
===========================================
  Hits            49594    49594           
  Misses          26953    26953           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ada5c...364035c. Read the comment docs.

@phil-davis phil-davis merged commit ddb0c38 into stable10 Apr 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-readme-installation-link branch April 17, 2019 12:36
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants