Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to current installation instructions in README #35036

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

phil-davis
Copy link
Contributor

Description

Change link to installation instructions so that it goes to the admin manual, and not to a 404 in the developer manual.

Related Issue

Motivation and Context

How Has This Been Tested?

Click on the link and it works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Looking back in the history of README.md this link seems to have been pointing into the developer manual - and now it happens to be a 404, which is why I noticed it.

What was the intention here? Did someone (also) want link(s) to the developer documentation in general or, e.g. "how to setup your developer environment" and/or "how to write an app"...?

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #35036 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35036      +/-   ##
============================================
+ Coverage     65.37%   65.37%   +<.01%     
  Complexity    18622    18622              
============================================
  Files          1215     1215              
  Lines         70510    70510              
  Branches       1295     1295              
============================================
+ Hits          46095    46096       +1     
+ Misses        24041    24040       -1     
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.82% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.68% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...17c238a. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #35036 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35036   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.81% <ø> (ø) 18622 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...3d28b7d. Read the comment docs.

Copy link
Contributor

@patrickjahns patrickjahns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

README.md Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor Author

Backport stable10 #35037

@phil-davis phil-davis merged commit 3f64c00 into master Apr 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the readme-installation-link branch April 17, 2019 12:26
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md installation instructions link is a 404
3 participants