[stable10] drone mariadb 10.3 #35785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… merged and released
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
phil-davis
commented
Jul 9, 2019
| @@ -737,6 +737,13 @@ matrix: | |||
| INSTALL_SERVER: true | |||
| INSTALL_TESTING_APP: true | |||
|
|
|||
| - PHP_VERSION: 7.1 | |||
There was a problem hiding this comment.
note: this is already in an earlier commit from "future drop php 7.0" - so at the moment we get these mariadb:10.3 unit tests run twice. No harm in that!
phil-davis
commented
Jul 9, 2019
| TEST_SUITE: phpunit | ||
| COVERAGE: true | ||
| INSTALL_SERVER: true | ||
| INSTALL_TESTING_APP: true |
There was a problem hiding this comment.
this line should not have been deleted.
That caused the fails in https://drone.owncloud.com/owncloud/core/19318/172
|
It looks like this can work. See #35786 for a version with commits cherry-picked in a better order etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On top of #34936 [stable10] future drop php 7.0
Backport #33255 Add mariadb 10.3 + mysql 8 to Drone, remove 10.2 workarounds
And see if we get CI passing
Related Issue
Motivation and Context
How Has This Been Tested?
CI