-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop php 7.0 [DO NOT MERGE YET] #35786
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #35786 +/- ##
===============================================
- Coverage 64.84% 45.68% -19.16%
===============================================
Files 1299 116 -1183
Lines 77220 11519 -65701
Branches 1301 1301
===============================================
- Hits 50070 5263 -44807
+ Misses 26765 5871 -20894
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35786 +/- ##
==============================================
+ Coverage 65.1% 65.19% +0.09%
+ Complexity 20197 20136 -61
==============================================
Files 1302 1299 -3
Lines 77158 77011 -147
Branches 1301 1301
==============================================
- Hits 50232 50207 -25
+ Misses 26541 26419 -122
Partials 385 385
Continue to review full report at Codecov.
|
fd32961
to
fa73bcf
Compare
CI green. This is the best effort so far to drop PHP 7.0 |
4488486
to
c6ca9d6
Compare
51ce708
to
9de6708
Compare
@DeepDiver1975 @patrickjahns @micbar I have found what I can for I suggest just give "comment" reviews. Do not click "Approve" yet. This can only actually be merged once we have decided which release will drop PHP 7.0 support. |
fde1b82
to
da6d66a
Compare
da6d66a
to
6bbddd6
Compare
Minor mobile view adjustments for portrait mode
changes needed for files_lifecycle tests
Revert void return type declarations that are not valid in PHP 7.0
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
… merged and released
…trine/dbal since 2.6.4
6bbddd6
to
698a01a
Compare
…P 7.0" This reverts commit 2a7d8ea.
This PR has got various extra commits in it, because it came from |
There are some phpunit on PHP 7.0 jobs that are still in drone. I have removed those in the next PR. |
Description
This PR is a place to put things that are waiting to go into
stable10
but that require PHP7.1+ and so cannot be merged until PHP7.0 support can be dropped.phpunit-mock-objects
change never got into a release with dependencies for phpunit6)stable10
)doctrine/dbal
version bump that comes when composer PHP 7.1 happens)Related Issue
#29483 MariaDB
#33187 PostgreSQL 10
Motivation and Context
Get
stable10
closer tomaster
and support newer databases.How Has This Been Tested?
CI
Types of changes
Checklist: