-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] drop php 7.0 and add phpunit7 #35789
[stable10] drop php 7.0 and add phpunit7 #35789
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #35789 +/- ##
==============================================
- Coverage 64.84% 64.71% -0.13%
+ Complexity 20243 19487 -756
==============================================
Files 1299 1298 -1
Lines 77220 76901 -319
Branches 1301 1301
==============================================
- Hits 50070 49770 -300
+ Misses 26765 26746 -19
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35789 +/- ##
==============================================
- Coverage 65.09% 64.71% -0.38%
+ Complexity 20239 19487 -752
==============================================
Files 1300 1298 -2
Lines 77238 76901 -337
Branches 1301 1301
==============================================
- Hits 50279 49770 -509
- Misses 26574 26746 +172
Partials 385 385
Continue to review full report at Codecov.
|
CI green - great stuff. |
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
… merged and released
8017155
to
bd9754f
Compare
Later version is #35804 |
Description
Combination of
#35774 "Introduce phpstan" (note: has now been merged to
stable10
)#35786 "drop PHP 7.0"
#34921 Bump phpunit7 (backport)
Extra commit: "Update method signatures for EncryptionTrait markTestSkipped and assertTrue" to fix a problem reported in the encryption unit test code (which is not in
master
), to fix:Related Issue
Motivation and Context
See if it passes all together.
How Has This Been Tested?
CI
Types of changes
Checklist: