Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/dbal from 2.7.1 to 2.8.0 #32065

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 16, 2018

Bumps doctrine/dbal from 2.7.1 to 2.8.0.

Release notes

Sourced from doctrine/dbal's releases.

Release v2.8.0

Build Status

This is a minor release of Doctrine DBAL that aggregates over 30 fixes and improvements developed over the last 3 months.

This release includes all changes of the 2.7.x series, as well as feature additions and improvements that couldn’t land in patch releases.

Backwards Compatibility Breaks

This doesn't contain any intentional Backwards Compatibility (BC) breaks.

Dependency Changes

Please see details in the UPGRADE.md documentation.

Deprecations

  • The usage of binary fields whose length exceeds the maximum field size on a given platform is deprecated. Please use binary fields of a size which fits all target platforms, or use blob explicitly instead.
  • The usage of DB-generated UUIDs is deprecated. Their format is inconsistent across supported platforms and therefore the feature is not portable. Use a PHP library (e.g. ramsey/uuid) to generate UUIDs on the application side.

New features

  • Initial support of MySQL 8.
  • Initial support of PostgreSQL 11.
  • Ability to evaluate arbitrary SQL expressions via AbstractPlatform::getDummySelectSQL().

Improvements and Fixes

  • Improved support of binary fields on Oracle and IBM DB2.
  • Improved SQL Server configuration capabilities via both sqlsrv and pdo_sqlsrv.
  • Improved handling of AUTOINCREMENTed primary keys in SQLite.
  • Integration tests are run against IBM DB2 on Travis CI.
  • Code coverage is collected for the Oracle platform on continuousphp.

Total issues resolved: 33

Deprecations:

New Features:

... (truncated)
Commits
  • 5140a64 Release v2.8.0
  • 3e2bee7 Merge pull request #3212 from morozov/bpo/2.8/3167
  • caf55ee Deprecated usage of DB-generated UUIDs
  • d475ade Merge pull request #3207 from Majkl578/cleanup
  • 0b770ba Drop legacy submodules, empty README and ORM leftovers
  • 0f2b537 Merge pull request #3199 from Majkl578/allow-sf4-console
  • f54ea21 Merge pull request #3204 from Majkl578/typo
  • 64a32a0 Allow symfony/console 4.x dev-dependency
  • c9103df Fix typo in AbstractPlatform
  • 51aeefa Merge pull request #3205 from Majkl578/fix-phpstan-oci
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@DeepDiver1975 DeepDiver1975 self-requested a review July 17, 2018 10:35
@DeepDiver1975 DeepDiver1975 self-assigned this Jul 17, 2018
@DeepDiver1975 DeepDiver1975 added this to the development milestone Jul 17, 2018
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ php occ maintenance:install -vvv --database=sqlite --database-name=owncloud --database-table-prefix=oc_ --admin-user=admin --admin-pass=admin --data-dir=/drone/src/data
waiting for database to be ready
creating sqlite db
Error while trying to create admin user: An exception occurred while executing 'CREATE TABLE "oc_storages" ("id" VARCHAR(64) DEFAULT NULL, "numeric_id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL PRIMARY KEY AUTOINCREMENT, "available" INTEGER DEFAULT 1 NOT NULL, "last_checked" INTEGER DEFAULT NULL)':

SQLSTATE[HY000]: General error: 1 table "oc_storages" has more than one primary key

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/doctrine/dbal-2.8.0 branch from 0da1385 to 1d46ab8 Compare July 24, 2018 07:35
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #32065 into master will decrease coverage by 10.93%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #32065       +/-   ##
=============================================
- Coverage     63.75%   52.81%   -10.94%     
=============================================
  Files          1170       61     -1109     
  Lines         69728     7166    -62562     
  Branches       1267     1267               
=============================================
- Hits          44452     3785    -40667     
+ Misses        24907     3012    -21895     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.81% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit ? ?
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Auth/PublicKey/RSA.php
core/Middleware/TwoFactorMiddleware.php
lib/private/Repair/CleanTags.php
core/Command/Encryption/Disable.php
settings/Panels/Personal/Clients.php
settings/Panels/Personal/Quota.php
lib/private/Files/Node/AbstractNode.php
...updatenotification/lib/ResetTokenBackgroundJob.php
lib/public/Files/StorageTimeoutException.php
...amework/Middleware/Security/SecurityMiddleware.php
... and 1099 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1097910...5cb7abb. Read the comment docs.

Bumps [doctrine/dbal](https://github.com/doctrine/dbal) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/doctrine/dbal/releases)
- [Commits](doctrine/dbal@v2.7.1...v2.8.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/doctrine/dbal-2.8.0 branch from 1d46ab8 to f2898f7 Compare July 24, 2018 07:40
@DeepDiver1975
Copy link
Member

Change which is causing us to break: doctrine/dbal#3141

@DeepDiver1975
Copy link
Member

failing acceptance tests are unrelated

@DeepDiver1975 DeepDiver1975 merged commit 508f72c into master Jul 24, 2018
@DeepDiver1975 DeepDiver1975 deleted the dependabot/composer/doctrine/dbal-2.8.0 branch July 24, 2018 10:28
@phil-davis
Copy link
Contributor

When stable10 moves forward (e.g. dropping PHP7.0) then a newer doctrine/dbal comes, and the 2nd commit from here has to be backported.

@phil-davis phil-davis mentioned this pull request Mar 30, 2019
10 tasks
@phil-davis phil-davis mentioned this pull request Jul 9, 2019
10 tasks
@phil-davis phil-davis mentioned this pull request Oct 18, 2019
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants