-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 10.4] Drop php 7.0 #36289
[For 10.4] Drop php 7.0 #36289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36289 +/- ##
============================================
- Coverage 65.18% 65.15% -0.03%
+ Complexity 19794 19733 -61
============================================
Files 1271 1268 -3
Lines 74730 74581 -149
Branches 1309 1309
============================================
- Hits 48712 48593 -119
+ Misses 25632 25602 -30
Partials 386 386
Continue to review full report at Codecov.
|
This is a rebased-refactor of PR #35961 that works with the new @DeepDiver1975 @PVince81 @micbar and others please review to see what is good/needs fixing or has been forgotten. Just make review comments - probably best not to click "approve" just yet (or someone might merge it) Then it will be here ready for whenever the decision is made to release "drop PHP 7.0" |
cdb62d9
to
81562e6
Compare
3fe8bc9
to
d08d16b
Compare
a111f24
to
24fda18
Compare
9a0e61e
to
af9448a
Compare
af9448a
to
3dc6490
Compare
@PVince81 @DeepDiver1975 @micbar this is ready for review. |
… merged and released
…trine/dbal since 2.6.4
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
…P 7.0" This reverts commit 2a7d8ea.
3dc6490
to
967ccac
Compare
Note: the changes here were merged as part of #36290 |
Description
Note: please review #36290 first. If that is OK then we can merge #36290 and close this PR.
This PR is a place to put things that are waiting to go into
stable10
but that require PHP7.1+ and so cannot be merged until PHP7.0 support can be dropped.phpunit-mock-objects
change never got into a release with dependencies for phpunit6)stable10
which is nowadaysmaster
)doctrine/dbal
version bump that comes when composer PHP 7.1 happens)Related Issue
#29483 MariaDB
#33187 PostgreSQL 10
Motivation and Context
Gather all the changes required for "drop PHP7.0" and related support for newer MariaDB and PostgreSQL versions... that were in the "old" master, and have them ready for "new" master.
How Has This Been Tested?
CI
Types of changes
Checklist: