Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For 10.4] Drop php 7.0 #36289

Closed
wants to merge 18 commits into from
Closed

[For 10.4] Drop php 7.0 #36289

wants to merge 18 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 18, 2019

Description

Note: please review #36290 first. If that is OK then we can merge #36290 and close this PR.

This PR is a place to put things that are waiting to go into stable10 but that require PHP7.1+ and so cannot be merged until PHP7.0 support can be dropped.

  1. From PR Add mariadb 10.3 + mysql 8 to Drone, remove 10.2 workarounds #33255 "Add mariadb 10.3 + mysql 8 to Drone, remove 10.2 workarounds' (5 commits)
  2. Drop PHP 7.0
  • Increase version to 10.1 prealpha #28043 Increase version to PHP7.1 (the remaining commits from that PR that relate to PHP7.1 and thus have never been applied yet)
  • Set min PHP version to 7.1
  • PHP 7.1+ is required
  • "[Workaround] .... until Fix mocking of interface which extend Throwable sebastianbergmann/phpunit-mock-objects#402 is merged and released" 407a70d (I think this will be needed as long as we are on phpunit6, because that phpunit-mock-objects change never got into a release with dependencies for phpunit6)
  • (other commits from Increase version to 10.1 prealpha #28043 are already back in stable10 which is nowadays master)
  • Bump doctrine/dbal from 2.7.1 to 2.8.0 #32065 2nd commit "Remove our own sqlite autoincrement hack" (needed with doctrine/dbal version bump that comes when composer PHP 7.1 happens)
  • Adjust drone for PHP7.1 like master (remaining drone adjustments)
  • Use is_iterable for PHP7.1 (to match more modern test code from archive/master)
  • Update to PHP 7.1 in travis - in case we use it to run UI tests on other browsers
  • Put back empty line in db_structure.xml that was removed by PR 34783 (resolves a minor diff between old stable10 and old master)
  • Remove special PHP7.0 checks from Makefile
  1. support PostgreSQL 10.3
  1. put back some test code that was for PHP 7.1-only (ref PR: Revert void return type declarations that are not valid in PHP 7.0 #35958 )

Related Issue

#29483 MariaDB
#33187 PostgreSQL 10

Motivation and Context

Gather all the changes required for "drop PHP7.0" and related support for newer MariaDB and PostgreSQL versions... that were in the "old" master, and have them ready for "new" master.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #36289 into master will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36289      +/-   ##
============================================
- Coverage     65.18%   65.15%   -0.03%     
+ Complexity    19794    19733      -61     
============================================
  Files          1271     1268       -3     
  Lines         74730    74581     -149     
  Branches       1309     1309              
============================================
- Hits          48712    48593     -119     
+ Misses        25632    25602      -30     
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.38% <77.77%> (-0.03%) 19733 <18> (-61)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 89.85% <ø> (-0.94%) 20 <0> (-1)
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/comments/tests/unit/Dav/EntityCollectionTest.php 100% <100%> (ø) 8 <7> (ø) ⬇️
lib/private/DB/MySqlTools.php 88.46% <82.35%> (+88.46%) 11 <11> (+7) ⬆️
lib/private/DB/Connection.php 67.64% <0%> (-2.95%) 49% <0%> (ø)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 16% <0%> (-1%) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (ø) 110% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee3233...967ccac. Read the comment docs.

@phil-davis phil-davis marked this pull request as ready for review October 18, 2019 05:45
@phil-davis phil-davis changed the title [WIP] Drop php 7.0 20191018 [THINK BEFORE MERGING] Drop php 7.0 20191018 Oct 18, 2019
@phil-davis
Copy link
Contributor Author

phil-davis commented Oct 18, 2019

This is a rebased-refactor of PR #35961 that works with the new .drone.starlark and other recent changes in master. It is the stuff that needs to happen/is waiting to happen when we drop PHP 7.0 support.

@DeepDiver1975 @PVince81 @micbar and others please review to see what is good/needs fixing or has been forgotten. Just make review comments - probably best not to click "approve" just yet (or someone might merge it)

Then it will be here ready for whenever the decision is made to release "drop PHP 7.0"

@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch 5 times, most recently from cdb62d9 to 81562e6 Compare October 29, 2019 09:54
@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch 3 times, most recently from 3fe8bc9 to d08d16b Compare November 7, 2019 07:43
@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch 3 times, most recently from a111f24 to 24fda18 Compare November 14, 2019 01:18
@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch 2 times, most recently from 9a0e61e to af9448a Compare November 21, 2019 06:33
@micbar micbar changed the title [THINK BEFORE MERGING] Drop php 7.0 20191018 [For 10.4] Drop php 7.0 20191018 Nov 25, 2019
@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch from af9448a to 3dc6490 Compare November 26, 2019 03:37
@phil-davis
Copy link
Contributor Author

@PVince81 @DeepDiver1975 @micbar this is ready for review.
(and then merge at the appropriate time when we are happy/confident to start moving master towards a 10.4 release)
Feel free to delegate reviewing to someone else!

@phil-davis phil-davis force-pushed the drop-php-7.0-20191018 branch from 3dc6490 to 967ccac Compare November 28, 2019 06:18
@phil-davis phil-davis changed the title [For 10.4] Drop php 7.0 20191018 [For 10.4] Drop php 7.0 Nov 28, 2019
@phil-davis
Copy link
Contributor Author

Note: the changes here were merged as part of #36290

@phil-davis phil-davis deleted the drop-php-7.0-20191018 branch June 18, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants