Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Remove skip/toImplementOnOcis tags for passing sharing tests #37774

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Aug 4, 2020

Description

This PR removes skip tags and toImplementOnOCIS tags for the tests that have been already implemented or pass on ocis. Also, toImplementOnOCIS tag is added for the scenarios with group sharing steps..

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #37774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37774   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19388    19388           
=========================================
  Files          1283     1283           
  Lines         75746    75746           
  Branches       1333     1333           
=========================================
  Hits          49020    49020           
  Misses        26334    26334           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19388.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 86.41% <0.00%> (ø) 58.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d0f7c...c537905. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #37774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37774   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19390    19390           
=========================================
  Files          1283     1283           
  Lines         75751    75751           
  Branches       1333     1333           
=========================================
  Hits          49021    49021           
  Misses        26338    26338           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19390.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7b33f...c1f425d. Read the comment docs.

@jasson99 jasson99 force-pushed the enablePassingSharingTests branch from c537905 to ff421e2 Compare August 5, 2020 07:08
@jasson99 jasson99 requested a review from phil-davis August 6, 2020 07:49
@jasson99 jasson99 self-assigned this Aug 10, 2020
@phil-davis phil-davis force-pushed the enablePassingSharingTests branch from 1b26663 to 2f75c6d Compare August 13, 2020 02:41
@phil-davis phil-davis force-pushed the enablePassingSharingTests branch from 2f75c6d to 305992a Compare August 20, 2020 03:51
@phil-davis phil-davis force-pushed the enablePassingSharingTests branch from 350a598 to 99fb701 Compare August 20, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants