Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Remove skip/toImplementOnOcis tags for passing sharing tests #37774

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[Tests-Only] Remove skip/toImplementOnOcis tags for passing sharing tests #37774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions tests/acceptance/features/apiShareManagement/acceptShares.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @files_sharing-app-required @toImplementOnOCIS @issue-ocis-reva-34 @issue-ocis-reva-41 @issue-ocis-reva-243
@api @files_sharing-app-required @issue-ocis-reva-34 @issue-ocis-reva-41 @issue-ocis-reva-243
Feature: accept/decline shares coming from internal users
As a user
I want to have control of which received shares I accept
Expand All @@ -16,7 +16,7 @@ Feature: accept/decline shares coming from internal users
And user "Brian" has been added to group "grp1"
And user "Carol" has been added to group "grp1"

@smokeTest
@smokeTest @toImplementOnOCIS
Scenario Outline: share a file & folder with another internal user with different permissions when auto accept is enabled
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
When user "Alice" creates a share using the sharing API with settings
Expand Down Expand Up @@ -46,6 +46,7 @@ Feature: accept/decline shares coming from internal users
| change |
| all |

@toImplementOnOCIS
Scenario Outline: share a file & folder with another internal user when auto accept is enabled and there is a default folder for received shares
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And the administrator has set the default folder for received shares to "<share_folder>"
Expand All @@ -72,6 +73,7 @@ Feature: accept/decline shares coming from internal users
| ReceivedShares | /ReceivedShares | | PARENT | textfile0.txt |
| /My/Received/Shares | /My/Received/Shares | | PARENT | textfile0.txt |

@toImplementOnOCIS
Scenario Outline: share a file & folder with internal group with different permissions when auto accept is enabled
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
When user "Alice" creates a share using the sharing API with settings
Expand Down Expand Up @@ -112,7 +114,7 @@ Feature: accept/decline shares coming from internal users
| change |
| all |

@smokeTest
@smokeTest @toImplementOnOCIS
Scenario: decline a share that has been auto-accepted
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has shared folder "/PARENT" with user "Brian"
Expand All @@ -130,6 +132,7 @@ Feature: accept/decline shares coming from internal users
| /PARENT/ |
| /textfile0.txt |

@toImplementOnOCIS
Scenario: accept a share that has been declined before
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has shared folder "/PARENT" with user "Brian"
Expand Down Expand Up @@ -164,6 +167,7 @@ Feature: accept/decline shares coming from internal users
| /PARENT/ |
| /textfile0.txt |

@toImplementOnOCIS
Scenario: unshare a share that was shared with a group and auto-accepted
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has shared folder "/PARENT" with group "grp1"
Expand All @@ -187,6 +191,7 @@ Feature: accept/decline shares coming from internal users
| /PARENT (2)/ |
| /textfile0 (2).txt |

@toImplementOnOCIS
Scenario: rename accepted share, decline it
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has shared folder "/PARENT" with user "Brian"
Expand All @@ -201,6 +206,7 @@ Feature: accept/decline shares coming from internal users
| path |
| /PARENT/ |

@toImplementOnOCIS
Scenario: rename accepted share, decline it then accept again, name stays
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has shared folder "/PARENT" with user "Brian"
Expand All @@ -216,6 +222,7 @@ Feature: accept/decline shares coming from internal users
| path |
| /PARENT-renamed/ |

@toImplementOnOCIS
Scenario: move accepted share, decline it, accept again
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has created folder "/shared"
Expand All @@ -233,6 +240,7 @@ Feature: accept/decline shares coming from internal users
| path |
| /PARENT/shared/ |

@toImplementOnOCIS
Scenario: move accepted share, decline it, delete parent folder, accept again
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has created folder "/shared"
Expand All @@ -251,6 +259,7 @@ Feature: accept/decline shares coming from internal users
| path |
| /shared/ |

@toImplementOnOCIS
Scenario: receive two shares with identical names from different users
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And user "Alice" has created folder "/shared"
Expand All @@ -269,7 +278,7 @@ Feature: accept/decline shares coming from internal users
| /shared/ |
| /shared (2)/ |

@smokeTest
@smokeTest @toImplementOnOCIS
Scenario: share a file & folder with another internal group when auto accept is disabled
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"
When user "Alice" shares folder "/PARENT" with group "grp1" using the sharing API
Expand Down Expand Up @@ -473,6 +482,7 @@ Feature: accept/decline shares coming from internal users
And user "Alice" deletes file "/textfile0.txt" using the WebDAV API
Then the sharing API should report that no shares are shared with user "Brian"

@toImplementOnOCIS
Scenario: only one user in a group accepts a share
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"
And user "Alice" has shared folder "/PARENT" with group "grp1"
Expand Down Expand Up @@ -518,6 +528,7 @@ Feature: accept/decline shares coming from internal users
| /shared/ |
| /shared (2)/ |

@toImplementOnOCIS
Scenario: share with a group that you are part of yourself
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"
When user "Alice" shares folder "/PARENT" with group "grp1" using the sharing API
Expand Down Expand Up @@ -588,6 +599,7 @@ Feature: accept/decline shares coming from internal users
And the content of file "/PARENT (2)/abc.txt" for user "Brian" should be "uploaded content"
And the content of file "/FOLDER (2)/abc.txt" for user "Brian" should be "uploaded content"

@toImplementOnOCIS
Scenario: user shares folder in a group with matching folder-name for every users involved
Given user "Alice" uploads file with content "uploaded content" to "/PARENT/abc.txt" using the WebDAV API
And user "Alice" uploads file with content "uploaded content" to "/FOLDER/abc.txt" using the WebDAV API
Expand Down Expand Up @@ -620,6 +632,7 @@ Feature: accept/decline shares coming from internal users
And the content of file "/PARENT (2)/abc.txt" for user "Carol" should be "uploaded content"
And the content of file "/FOLDER (2)/abc.txt" for user "Carol" should be "uploaded content"

@toImplementOnOCIS
Scenario: user shares files in a group with matching file-names for every users involved in sharing
When user "Alice" shares file "/textfile0.txt" with group "grp1" using the sharing API
And user "Alice" shares file "/textfile1.txt" with group "grp1" using the sharing API
Expand Down Expand Up @@ -656,6 +669,7 @@ Feature: accept/decline shares coming from internal users
| /PARENT%20(2)/ |
| /textfile0%20(2).txt |

@toImplementOnOCIS
Scenario: user shares file in a group with matching filename when auto accept is disabled
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"
When user "Alice" shares file "/textfile0.txt" with group "grp1" using the sharing API
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiShareOperations/accessToShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Feature: sharing
| 1 | 100 |
| 2 | 200 |

@smokeTest @issue-ocis-reva-34 @issue-ocis-reva-194
@smokeTest @issue-ocis-reva-34 @issue-ocis-reva-194 @toImplementOnOCIS
Scenario Outline: Sharee can see the group share
Given using OCS API version "<ocs_api_version>"
And group "grp1" has been created
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiShareOperations/gettingShares.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Feature: sharing
| 1 | 200 |
| 2 | 404 |

@skipOnLDAP @issue-ocis-reva-194
@skipOnLDAP @issue-ocis-reva-194 @toImplementOnOCIS
Scenario: Share of folder to a group, remove user from that group
Given using OCS API version "1"
And user "Carol" has been created with default attributes and skeleton files
Expand Down
3 changes: 3 additions & 0 deletions tests/acceptance/features/bootstrap/AppConfigurationContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ public function adminSetsServerParameterToUsingAPI(
public function serverParameterHasBeenSetTo($parameter, $app, $value) {
// The capturing group of the regex always includes the quotes at each
// end of the captured string, so trim them.
if (\TestHelpers\OcisHelper::isTestingOnOcis()) {
return;
}
$value = \trim($value, $value[0]);
$this->adminSetsServerParameterToUsingAPI($parameter, $app, $value);
}
Expand Down