Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Adds test for sharing resource with sharee that has an existing resource with diff. case name #38950

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[Tests-Only] Adds test for sharing resource with sharee that has an existing resource with diff. case name #38950

merged 1 commit into from
Jul 13, 2021

Conversation

sakshamgurung
Copy link
Contributor

@sakshamgurung sakshamgurung commented Jul 7, 2021 •
edited
Loading

Description

  • Adds API test for for sharing resource with sharee that has an existing resource with different case sensitive name

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sakshamgurung sakshamgurung marked this pull request as ready for review July 8, 2021 03:32
@sakshamgurung sakshamgurung force-pushed the share-resource-case-sensitive-name branch from 1da6596 to 45b15f4 Compare July 8, 2021 05:21
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31012/125/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31012/126/1

@jasson99 jasson99 changed the title [test-only] Adds test for sharing resource with sharee that has an existing resource with diff. case name [Tests-Only] Adds test for sharing resource with sharee that has an existing resource with diff. case name Jul 8, 2021
jasson99
jasson99 reviewed Jul 8, 2021
View reviewed changes
...cceptance/features/apiShareCreateSpecialToRoot1/createShareResourceCaseSensitiveName.feature Outdated
| Brian |

Scenario Outline: sharing file with user sharee that has an existing file with different case name
Given using OCS API version "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, This step can go into background.

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31013/125/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31013/126/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31013/127/1

@sakshamgurung
Copy link
Contributor Author

Why CI/CD is failing?

@kiranparajuli589
Copy link
Contributor

some suites failed in install-core steps https://drone.owncloud.com/owncloud/core/31013/125/1
this can happen sometimes due to network failures.
please restart the CI.

@sakshamgurung sakshamgurung force-pushed the share-resource-case-sensitive-name branch from 45b15f4 to f996bd9 Compare July 8, 2021 07:16
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingExt1-git-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31014/159/1

@sakshamgurung sakshamgurung force-pushed the share-resource-case-sensitive-name branch from f996bd9 to 9b27b0f Compare July 8, 2021 11:25
SwikritiT
SwikritiT reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakshamgurung sakshamgurung force-pushed the share-resource-case-sensitive-name branch from 9b27b0f to 905c200 Compare July 9, 2021 11:15
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToShares1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31061/114/1

@sakshamgurung
adds test for sharing resources with same name different case and che…
3b3d4fa 
…cking for coexistence on sharee/receiver side
@sakshamgurung sakshamgurung force-pushed the share-resource-case-sensitive-name branch from 905c200 to 3b3d4fa Compare July 12, 2021 05:57
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

swoichha
swoichha approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@swoichha swoichha requested a review from phil-davis July 13, 2021 04:55
@owncloud owncloud deleted a comment from update-docs bot Jul 13, 2021
@phil-davis phil-davis merged commit 845470d into owncloud:master Jul 13, 2021
@phil-davis phil-davis mentioned this pull request Jul 13, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@jasson99 jasson99 jasson99 left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@Talank Talank Talank left review comments

@swoichha swoichha swoichha approved these changes

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@sakshamgurung sakshamgurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sakshamgurung @ownclouders @kiranparajuli589 @phil-davis @swoichha @Talank @jasson99 @SwikritiT @saw-jan