Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Adjust minor words in API sharing test steps #38983

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

phil-davis
Copy link
Contributor

Description

Minor adjustments to test step wording that was introduced in PR #38950

Note: there are a lot of uses of file|folder|entry or files|folders|entries in the core test code. But in owncloud/web we call "file or folder" a "resource", which is also the way we commonly refer to "file or folder" in reva, OCIS etc. So we should update that in the core tests to be consistent. But that can wait until after 10.8.0 is released - we don't want to do big test-code-refactoring until after release-10.8.0 branch is merged back to master

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jul 13, 2021
@phil-davis phil-davis requested review from individual-it, swoichha and jasson99 and removed request for individual-it July 13, 2021 08:31
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the commit id in ocis & reva

@phil-davis phil-davis merged commit 24bc267 into master Jul 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-adjustments-20210713 branch July 14, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants